[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250430072355.73a79f55@kernel.org>
Date: Wed, 30 Apr 2025 07:23:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jeff Layton <jlayton@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Jani Nikula
<jani.nikula@...ux.intel.com>, Joonas Lahtinen
<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
Tvrtko Ursulin <tursulin@...ulin.net>, Kuniyuki Iwashima
<kuniyu@...zon.com>, Qasim Ijaz <qasdev00@...il.com>, Nathan Chancellor
<nathan@...nel.org>, Andrew Lunn <andrew@...n.ch>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH v5 04/10] ref_tracker: allow pr_ostream() to print
directly to a seq_file
On Tue, 29 Apr 2025 19:18:01 -0700 Jeff Layton wrote:
> On Tue, 2025-04-29 at 16:27 -0700, Jakub Kicinski wrote:
> > On Mon, 28 Apr 2025 11:26:27 -0700 Jeff Layton wrote:
> > > Allow pr_ostream to also output directly to a seq_file without an
> > > intermediate buffer.
> > >
> > > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> > > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> >
> > lib/ref_tracker.c:316:12: warning: unused function 'ref_tracker_dir_seq_print' [-Wunused-function]
> > 316 | static int ref_tracker_dir_seq_print(struct ref_tracker_dir *dir, struct seq_file *seq)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> The caller ends up being added in patch #6. I think the only thing I
> can do here to silence this is to squash this patch into that one.
>
> I kind of don't like doing that here because I think the patches are
> conceptually separate, and it'll make for a rather large patch.
>
> Let me know what you prefer.
Would it work to make the fops very dumbed down - return an error
from open. And then implement the seqfile output as the next patch?
Powered by blists - more mailing lists