| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250430163157.15508066@booty> Date: Wed, 30 Apr 2025 16:31:57 +0200 From: Luca Ceresoli <luca.ceresoli@...tlin.com> To: Cosmin Tanislav <demonsingur@...il.com> Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, Wolfram Sang <wsa+renesas@...g-engineering.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Romain Gantois <romain.gantois@...tlin.com>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com> Subject: Re: [PATCH v4 1/9] i2c: atr: Fix lockdep for nested ATRs On Mon, 28 Apr 2025 13:25:06 +0300 Cosmin Tanislav <demonsingur@...il.com> wrote: > From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com> > > When we have an ATR, and another ATR as a subdevice of the first ATR, > we get lockdep warnings for the i2c_atr.lock and > i2c_atr_chan.orig_addrs_lock. This is because lockdep uses a static key > for the locks, and doesn't see the locks of the separate ATR instances > as separate. > > Fix this by generating a dynamic lock key per lock instance. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com> I'm not very qualified about the lockdep side of the changes, but regarding the ATR side this looks OK: Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com> -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Powered by blists - more mailing lists