Message-ID: <4729bf25-5044-4c21-b37a-0270fc2b0a19@linux.dev>
Date: Wed, 30 Apr 2025 16:50:32 +0200
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: syzbot <syzbot+e2ce9e275ecc70a30b72@...kaller.appspotmail.com>,
 jgg@...pe.ca, leon@...nel.org, linux-kernel@...r.kernel.org,
 linux-rdma@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [rdma?] KASAN: slab-use-after-free Read in
 ib_register_device

在 2025/4/30 12:09, syzbot 写道:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    02ddfb981de8 Merge tag 'scsi-fixes' of git://git.kernel.or..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=11434368580000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=9f5bd2a76d9d0b4e
> dashboard link: https://syzkaller.appspot.com/bug?extid=e2ce9e275ecc70a30b72
> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
> 
> Unfortunately, I don't have any reproducer for this issue yet.
> 
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/37d29bf0bb8b/disk-02ddfb98.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/04b17f9932d8/vmlinux-02ddfb98.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/a1c7813f1b54/bzImage-02ddfb98.xz
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+e2ce9e275ecc70a30b72@...kaller.appspotmail.com

I suppose that the commit in the link: 
https://lore.kernel.org/all/20250313092421.944658-1-wangliang74@huawei.com/T/
can fix the problem in the link: 
https://syzkaller.appspot.com/bug?extid=25bc6f0ed2b88b9eb9b8

This problem is similar to the above problem.

And in this problem, it seems that the same name is also accessed 
lockless in the function kobject_uevent.

"
...
1470     dev_set_uevent_suppress(&device->dev, false);
1471     /* Mark for userspace that device is ready */
1472     kobject_uevent(&device->dev.kobj, KOBJ_ADD); <--- the name is 
also accessed lockless
...

"
Thus, the following can fix this problem?

diff --git a/drivers/infiniband/core/device.c 
b/drivers/infiniband/core/device.c
index b4e3e4beb7f4..811c6f95abcf 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -1468,8 +1468,10 @@ int ib_register_device(struct ib_device *device, 
const char *name,
                 return ret;
         }
         dev_set_uevent_suppress(&device->dev, false);
+       down_read(&devices_rwsem);
         /* Mark for userspace that device is ready */
         kobject_uevent(&device->dev.kobj, KOBJ_ADD);
+       up_read(&devices_rwsem);

         ib_device_notify_register(device);
         ib_device_put(device);

Zhu Yanjun

> 
> ==================================================================
> BUG: KASAN: slab-use-after-free in strlen+0x93/0xa0 lib/string.c:420
> Read of size 1 at addr ffff88801e6cfea1 by task syz.2.292/7048
> 
> CPU: 1 UID: 0 PID: 7048 Comm: syz.2.292 Not tainted 6.15.0-rc3-syzkaller-00094-g02ddfb981de8 #0 PREEMPT(full)
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
> Call Trace:
>   <TASK>
>   __dump_stack lib/dump_stack.c:94 [inline]
>   dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
>   print_address_description mm/kasan/report.c:408 [inline]
>   print_report+0xc3/0x670 mm/kasan/report.c:521
>   kasan_report+0xe0/0x110 mm/kasan/report.c:634
>   strlen+0x93/0xa0 lib/string.c:420
>   __fortify_strlen include/linux/fortify-string.h:268 [inline]
>   get_kobj_path_length lib/kobject.c:118 [inline]
>   kobject_get_path+0x3f/0x2a0 lib/kobject.c:158
>   kobject_uevent_env+0x289/0x1870 lib/kobject_uevent.c:545
>   ib_register_device drivers/infiniband/core/device.c:1472 [inline]
>   ib_register_device+0x8cf/0xe00 drivers/infiniband/core/device.c:1393
>   rxe_register_device+0x275/0x320 drivers/infiniband/sw/rxe/rxe_verbs.c:1552
>   rxe_net_add+0x8e/0xe0 drivers/infiniband/sw/rxe/rxe_net.c:550
>   rxe_newlink+0x70/0x190 drivers/infiniband/sw/rxe/rxe.c:225
>   nldev_newlink+0x3a3/0x680 drivers/infiniband/core/nldev.c:1796
>   rdma_nl_rcv_msg+0x387/0x6e0 drivers/infiniband/core/netlink.c:195
>   rdma_nl_rcv_skb.constprop.0.isra.0+0x2e5/0x450 drivers/infiniband/core/netlink.c:239
>   netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
>   netlink_unicast+0x53a/0x7f0 net/netlink/af_netlink.c:1339
>   netlink_sendmsg+0x8d1/0xdd0 net/netlink/af_netlink.c:1883
>   sock_sendmsg_nosec net/socket.c:712 [inline]
>   __sock_sendmsg net/socket.c:727 [inline]
>   ____sys_sendmsg+0xa95/0xc70 net/socket.c:2566
>   ___sys_sendmsg+0x134/0x1d0 net/socket.c:2620
>   __sys_sendmsg+0x16d/0x220 net/socket.c:2652
>   do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
>   do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
>   entry_SYSCALL_64_after_hwframe+0x77/0x7f
> RIP: 0033:0x7fb12658e969
> Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:00007fb127391038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
> RAX: ffffffffffffffda RBX: 00007fb1267b6080 RCX: 00007fb12658e969
> RDX: 0000000000000000 RSI: 0000200000000240 RDI: 0000000000000009
> RBP: 00007fb126610ab1 R08: 0000000000000000 R09: 0000000000000000
> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
> R13: 0000000000000000 R14: 00007fb1267b6080 R15: 00007ffe92b5e748
>   </TASK>
> 
> Allocated by task 7048:
>   kasan_save_stack+0x33/0x60 mm/kasan/common.c:47
>   kasan_save_track+0x14/0x30 mm/kasan/common.c:68
>   poison_kmalloc_redzone mm/kasan/common.c:377 [inline]
>   __kasan_kmalloc+0xaa/0xb0 mm/kasan/common.c:394
>   kasan_kmalloc include/linux/kasan.h:260 [inline]
>   __do_kmalloc_node mm/slub.c:4341 [inline]
>   __kmalloc_node_track_caller_noprof+0x221/0x510 mm/slub.c:4360
>   __kmemdup_nul mm/util.c:63 [inline]
>   kstrdup+0x53/0x100 mm/util.c:83
>   kstrdup_const+0x63/0x80 mm/util.c:103
>   kvasprintf_const+0x164/0x1a0 lib/kasprintf.c:46
>   kobject_set_name_vargs+0x5a/0x140 lib/kobject.c:274
>   dev_set_name+0xc7/0x100 drivers/base/core.c:3469
>   assign_name drivers/infiniband/core/device.c:1211 [inline]
>   ib_register_device+0x7df/0xe00 drivers/infiniband/core/device.c:1398
>   rxe_register_device+0x275/0x320 drivers/infiniband/sw/rxe/rxe_verbs.c:1552
>   rxe_net_add+0x8e/0xe0 drivers/infiniband/sw/rxe/rxe_net.c:550
>   rxe_newlink+0x70/0x190 drivers/infiniband/sw/rxe/rxe.c:225
>   nldev_newlink+0x3a3/0x680 drivers/infiniband/core/nldev.c:1796
>   rdma_nl_rcv_msg+0x387/0x6e0 drivers/infiniband/core/netlink.c:195
>   rdma_nl_rcv_skb.constprop.0.isra.0+0x2e5/0x450 drivers/infiniband/core/netlink.c:239
>   netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
>   netlink_unicast+0x53a/0x7f0 net/netlink/af_netlink.c:1339
>   netlink_sendmsg+0x8d1/0xdd0 net/netlink/af_netlink.c:1883
>   sock_sendmsg_nosec net/socket.c:712 [inline]
>   __sock_sendmsg net/socket.c:727 [inline]
>   ____sys_sendmsg+0xa95/0xc70 net/socket.c:2566
>   ___sys_sendmsg+0x134/0x1d0 net/socket.c:2620
>   __sys_sendmsg+0x16d/0x220 net/socket.c:2652
>   do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
>   do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
>   entry_SYSCALL_64_after_hwframe+0x77/0x7f
> 
> Freed by task 7111:
>   kasan_save_stack+0x33/0x60 mm/kasan/common.c:47
>   kasan_save_track+0x14/0x30 mm/kasan/common.c:68
>   kasan_save_free_info+0x3b/0x60 mm/kasan/generic.c:576
>   poison_slab_object mm/kasan/common.c:247 [inline]
>   __kasan_slab_free+0x51/0x70 mm/kasan/common.c:264
>   kasan_slab_free include/linux/kasan.h:233 [inline]
>   slab_free_hook mm/slub.c:2398 [inline]
>   slab_free mm/slub.c:4656 [inline]
>   kfree+0x2b6/0x4d0 mm/slub.c:4855
>   kfree_const+0x55/0x60 mm/util.c:45
>   kobject_rename+0x178/0x260 lib/kobject.c:524
>   device_rename+0x130/0x230 drivers/base/core.c:4526
>   ib_device_rename+0x113/0x5c0 drivers/infiniband/core/device.c:402
>   nldev_set_doit+0x3d7/0x4e0 drivers/infiniband/core/nldev.c:1147
>   rdma_nl_rcv_msg+0x387/0x6e0 drivers/infiniband/core/netlink.c:195
>   rdma_nl_rcv_skb.constprop.0.isra.0+0x2e5/0x450 drivers/infiniband/core/netlink.c:239
>   netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
>   netlink_unicast+0x53a/0x7f0 net/netlink/af_netlink.c:1339
>   netlink_sendmsg+0x8d1/0xdd0 net/netlink/af_netlink.c:1883
>   sock_sendmsg_nosec net/socket.c:712 [inline]
>   __sock_sendmsg net/socket.c:727 [inline]
>   ____sys_sendmsg+0xa95/0xc70 net/socket.c:2566
>   ___sys_sendmsg+0x134/0x1d0 net/socket.c:2620
>   __sys_sendmsg+0x16d/0x220 net/socket.c:2652
>   do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
>   do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
>   entry_SYSCALL_64_after_hwframe+0x77/0x7f
> 
> The buggy address belongs to the object at ffff88801e6cfea0
>   which belongs to the cache kmalloc-8 of size 8
> The buggy address is located 1 bytes inside of
>   freed 8-byte region [ffff88801e6cfea0, ffff88801e6cfea8)
> 
> The buggy address belongs to the physical page:
> page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1e6cf
> flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
> page_type: f5(slab)
> raw: 00fff00000000000 ffff88801b441500 ffffea00009f5200 dead000000000002
> raw: 0000000000000000 0000000000800080 00000000f5000000 0000000000000000
> page dumped because: kasan: bad access detected
> page_owner tracks the page as allocated
> page last allocated via order 0, migratetype Unmovable, gfp_mask 0x52cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP), pid 1, tgid 1 (swapper/0), ts 2371251963, free_ts 0
>   set_page_owner include/linux/page_owner.h:32 [inline]
>   post_alloc_hook+0x181/0x1b0 mm/page_alloc.c:1718
>   prep_new_page mm/page_alloc.c:1726 [inline]
>   get_page_from_freelist+0x135c/0x3920 mm/page_alloc.c:3688
>   __alloc_frozen_pages_noprof+0x263/0x23a0 mm/page_alloc.c:4970
>   alloc_pages_mpol+0x1fb/0x550 mm/mempolicy.c:2301
>   alloc_slab_page mm/slub.c:2468 [inline]
>   allocate_slab mm/slub.c:2632 [inline]
>   new_slab+0x244/0x340 mm/slub.c:2686
>   ___slab_alloc+0xd9c/0x1940 mm/slub.c:3872
>   __slab_alloc.constprop.0+0x56/0xb0 mm/slub.c:3962
>   __slab_alloc_node mm/slub.c:4037 [inline]
>   slab_alloc_node mm/slub.c:4198 [inline]
>   __do_kmalloc_node mm/slub.c:4340 [inline]
>   __kmalloc_noprof+0x2f2/0x510 mm/slub.c:4353
>   kmalloc_noprof include/linux/slab.h:909 [inline]
>   kzalloc_noprof include/linux/slab.h:1039 [inline]
>   acpi_ns_internalize_name+0x144/0x220 drivers/acpi/acpica/nsutils.c:331
>   acpi_ns_get_node_unlocked+0x163/0x310 drivers/acpi/acpica/nsutils.c:666
>   acpi_ns_get_node+0x4c/0x70 drivers/acpi/acpica/nsutils.c:726
>   acpi_ns_evaluate+0x6ef/0xca0 drivers/acpi/acpica/nseval.c:62
>   acpi_evaluate_object+0x1fa/0xa90 drivers/acpi/acpica/nsxfeval.c:354
>   acpi_evaluate_dsm+0x194/0x290 drivers/acpi/utils.c:797
>   acpi_check_dsm+0x51/0x260 drivers/acpi/utils.c:830
>   device_has_acpi_name drivers/pci/pci-label.c:44 [inline]
>   acpi_attr_is_visible+0xb3/0x130 drivers/pci/pci-label.c:221
> page_owner free stack trace missing
> 
> Memory state around the buggy address:
>   ffff88801e6cfd80: fa fc fc fc fa fc fc fc fa fc fc fc fa fc fc fc
>   ffff88801e6cfe00: fa fc fc fc fa fc fc fc fa fc fc fc 00 fc fc fc
>> ffff88801e6cfe80: 00 fc fc fc fa fc fc fc 02 fc fc fc 04 fc fc fc
>                                 ^
>   ffff88801e6cff00: fa fc fc fc 02 fc fc fc fa fc fc fc fa fc fc fc
>   ffff88801e6cff80: fa fc fc fc fa fc fc fc fa fc fc fc fa fc fc fc
> ==================================================================
> 
> 
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@...glegroups.com.
> 
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> 
> If the report is already addressed, let syzbot know by replying with:
> #syz fix: exact-commit-title
> 
> If you want to overwrite report's subsystems, reply with:
> #syz set subsystems: new-subsystem
> (See the list of subsystem names on the web dashboard)
> 
> If the report is a duplicate of another one, reply with:
> #syz dup: exact-subject-of-another-report
> 
> If you want to undo deduplication, reply with:
> #syz undup

Powered by blists - more mailing lists