linux-kernel - Re: [PATCH v3 2/3] firmware: arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250430-efficient-spider-of-criticism-e857bf@sudeepholla>
Date: Wed, 30 Apr 2025 16:26:17 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Cristian Marussi <cristian.marussi@....com>
Cc: Marc Zyngier <maz@...nel.org>, <linux-kernel@...r.kernel.org>,
	Sudeep Holla <sudeep.holla@....com>,
	<linux-arm-kernel@...ts.infradead.org>, <arm-scmi@...r.kernel.org>,
	<james.quinlan@...adcom.com>, <f.fainelli@...il.com>,
	<vincent.guittot@...aro.org>, <peng.fan@....nxp.com>,
	<michal.simek@....com>, <quic_sibis@...cinc.com>,
	<dan.carpenter@...aro.org>, <johan@...nel.org>,
	"Arnd Bergmann" <arnd@...nel.org>,
	Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH v3 2/3] firmware: arm_scmi: Add Quirks framework

+Arnd

On Wed, Apr 30, 2025 at 01:43:55PM +0100, Cristian Marussi wrote:
> On Wed, Apr 30, 2025 at 12:36:40PM +0100, Marc Zyngier wrote:
> > On Wed, 30 Apr 2025 08:54:06 +0100,
> > Cristian Marussi <cristian.marussi@....com> wrote:
> > > 
> > > On Tue, Apr 29, 2025 at 03:11:07PM +0100, Cristian Marussi wrote:
> > > > Add a common framework to describe SCMI quirks and associate them with a
> > > > specific platform or a specific set of SCMI firmware versions.
> > > > 
> > > > All the matching SCMI quirks will be enabled when the SCMI core stack
> > > > probes and after all the needed SCMI firmware versioning information was
> > > > retrieved using Base protocol.
> > > > 
> > > > Tested-by: Johan Hovold <johan+linaro@...nel.org>
> > > > Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> > > 
> > > Hi
> > > 
> > > just a quick remarks that a bot spotted the usage of __VA_OPT__ which is
> > > only available since GCC >= 8.0 :< ... so I will probably revert to use the
> > > previous, less clean, mechanism to build the NULL terminated array in
> > > which the compats array WILL HAVE to be explicitly NULL terminated when
> > > provided (even the empty ones...)
> > 
> > See 20250407094116.1339199-1-arnd@...nel.org, which is slated for
> > 6.16. The TL;DR is that GCC 8.1 and binutils 2.30 should be the
> > minimal versions from 6.16 onwards.
> > 
> > So it's probably not worth using ugly hacks that will eventually be
> > reverted.
> 
> Great news, thanks for the heads-up !
> 

Thanks Marc!

Arnd,

I don't see much discussions on 20250407094116.1339199-1-arnd@...nel.org
to conclude if you plan to get this for v6.16

We probably can wait to push this $subject after your changes land. But
it would be good to know your opinion here especially if you are not
pushing your patches for v6.16

-- 
Regards,
Sudeep