linux-kernel - Re: [PATCH 1/2] tpm_crb: ffa_tpm: fix cut/paste error in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBJCeoapwgdaPONq@kernel.org>
Date: Wed, 30 Apr 2025 18:32:10 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Stuart Yoder <stuart.yoder@....com>
Cc: linux-integrity@...r.kernel.org, peterhuewe@....de, jgg@...pe.ca,
	sudeep.holla@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] tpm_crb: ffa_tpm: fix cut/paste error in comment

On Tue, Apr 29, 2025 at 05:15:17PM -0500, Stuart Yoder wrote:
> Fix the comment for the 'start' function, which was a cut/paste
> mistake for a different function.
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@....com>
> ---
>  drivers/char/tpm/tpm_crb_ffa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c
> index 3169a87a56b60..65b01a46d4b88 100644
> --- a/drivers/char/tpm/tpm_crb_ffa.c
> +++ b/drivers/char/tpm/tpm_crb_ffa.c
> @@ -68,7 +68,8 @@
>  #define CRB_FFA_GET_INTERFACE_VERSION 0x0f000001
>  
>  /*
> - * Return information on a given feature of the TPM service
> + * Notifies the TPM service that a TPM command or TPM locality request is
> + * ready to be processed, and allows the TPM service to process it.
>   * Call register usage:
>   * w3:    Not used (MBZ)
>   * w4:    TPM service function ID, CRB_FFA_START
> -- 
> 2.34.1
> 

Can you squash the comment updates into single patch instead and
enumerate the changes? Does not really serve any purpose because
comments do not "run".

BR, Jarkko