linux-kernel - Re: [PATCH v2 0/2] vdso: Work around and reject absolute relocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAASaF6w4Y5oH+eWE_ap95H_zpewbjs05xY77oCfZd91qy8d5cg@mail.gmail.com>
Date: Wed, 30 Apr 2025 17:33:47 +0200
From: Jan Stancek <jstancek@...hat.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, 
	Nam Cao <namcao@...utronix.de>, Anna-Maria Behnsen <anna-maria@...utronix.de>, 
	Thomas Gleixner <tglx@...utronix.de>, Andy Lutomirski <luto@...nel.org>, 
	Vincenzo Frascino <vincenzo.frascino@....com>, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] vdso: Work around and reject absolute relocations

On Wed, Apr 30, 2025 at 11:23 AM Thomas Weißschuh
<thomas.weissschuh@...utronix.de> wrote:
>
> GCC on arm64 would incorrectly emit absolute relocations in vDSO code.
> Work around those and break the build if new ones appear.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
> Changes in v2:
> - Link to openend (invalid) GCC bug containing more explanations
> - Refine commit messages
> - Don't fail on commit absolute relocations in debug info
> - Link to v1: https://lore.kernel.org/r/20250429-vdso-absolute-reloc-v1-0-987a0afd10b5@linutronix.de

Tested-by: Jan Stancek <jstancek@...hat.com>

v2 works for me with both reproducers. LTP syscalls run passed as well.

I did a scratch builds of latest Fedora rawhide and ELN with this
series, both passed on all arches:
https://koji.fedoraproject.org/koji/taskinfo?taskID=132140190
https://koji.fedoraproject.org/koji/taskinfo?taskID=132137468


>
> ---
> Thomas Weißschuh (2):
>       arm64: vdso: Work around invalid absolute relocations from GCC
>       vdso: Reject absolute relocations during build
>
>  arch/arm64/include/asm/vdso/gettimeofday.h | 13 +++++++++++++
>  lib/vdso/Makefile.include                  |  6 ++++++
>  2 files changed, 19 insertions(+)
> ---
> base-commit: b4432656b36e5cc1d50a1f2dc15357543add530e
> change-id: 20250428-vdso-absolute-reloc-a226293c1761
>
> Best regards,
> --
> Thomas Weißschuh <thomas.weissschuh@...utronix.de>
>