linux-kernel - Re: [PATCH v1 2/3] selftests: pidfd: add missing sys/ioctl.h include in pidfd_setns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABdmKX3zM8NodtvCDgRJXAYrXydxbKsu7UXL=iWNbO5RW6-Cng@mail.gmail.com>
Date: Wed, 30 Apr 2025 09:20:56 -0700
From: "T.J. Mercier" <tjmercier@...gle.com>
To: Peter Seiderer <ps.report@....net>
Cc: linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>, 
	linux-kernel@...r.kernel.org, Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v1 2/3] selftests: pidfd: add missing sys/ioctl.h include
 in pidfd_setns_test.c

On Wed, Jan 15, 2025 at 2:53 AM Peter Seiderer <ps.report@....net> wrote:
>
> Fix compile on openSUSE Tumbleweed (gcc-14.2.1, glibc-2.40):
>   - add missing sys/ioctl.h include
>
> Fixes:
>
>   pidfd_setns_test.c: In function ‘current_nsset_setup’:
>   pidfd_setns_test.c:172:54: error: implicit declaration of function ‘ioctl’ [-Wimplicit-function-declaration]
>     172 |                 self->child_pidfd_derived_nsfds[i] = ioctl(self->pidfd, info->pidfd_ioctl, 0);
>         |                                                      ^~~~~
>
> Signed-off-by: Peter Seiderer <ps.report@....net>

Reviewed-by: T.J. Mercier <tjmercier@...gle.com>


> ---
>  tools/testing/selftests/pidfd/pidfd_setns_test.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/pidfd/pidfd_setns_test.c b/tools/testing/selftests/pidfd/pidfd_setns_test.c
> index 222f8131283b..4c8a0253a64f 100644
> --- a/tools/testing/selftests/pidfd/pidfd_setns_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_setns_test.c
> @@ -17,6 +17,7 @@
>  #include <sys/socket.h>
>  #include <sys/stat.h>
>  #include <linux/ioctl.h>
> +#include <sys/ioctl.h>
>
>  #include "pidfd.h"
>  #include "../kselftest_harness.h"
> --
> 2.47.1
>