linux-kernel - [PATCH] char: misc: make miscdevice unit test built-in only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250430-misc-test-fixup-v1-1-6f39ed6c733d@igalia.com>
Date: Wed, 30 Apr 2025 13:36:28 -0300
From: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Arnd Bergmann <arnd@...db.de>
Cc: linux-kernel@...r.kernel.org, linux-next@...r.kernel.org, 
 Stephen Rothwell <sfr@...b.auug.org.au>, 
 Andrew Morton <akpm@...ux-foundation.org>, kernel-dev@...lia.com, 
 kernel test robot <lkp@...el.com>, 
 Thadeu Lima de Souza Cascardo <cascardo@...lia.com>
Subject: [PATCH] char: misc: make miscdevice unit test built-in only

Since it uses __init symbols, it cannot be a module. Builds with
CONFIG_TEST_MISC_MINOR=m will fail with:

ERROR: modpost: "init_mknod" [drivers/misc/misc_minor_kunit.ko] undefined!
ERROR: modpost: "init_unlink" [drivers/misc/misc_minor_kunit.ko] undefined!

Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
Closes: https://lore.kernel.org/linux-next/20250429155404.2b6fe5b1@canb.auug.org.au/
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504160338.BjUL3Owb-lkp@intel.com/
Fixes: 45f0de4f8dc3 ("char: misc: add test cases")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>
---
 lib/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index f9051ab610d54358b21d61c141b737bb345b4cee..0117b852bd131b8a585dc02d8225e2e8c0740077 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2512,7 +2512,7 @@ config TEST_IDA
 	tristate "Perform selftest on IDA functions"
 
 config TEST_MISC_MINOR
-	tristate "miscdevice KUnit test" if !KUNIT_ALL_TESTS
+	bool "miscdevice KUnit test" if !KUNIT_ALL_TESTS
 	depends on KUNIT
 	default KUNIT_ALL_TESTS
 	help

---
base-commit: 4f822ad5ee944ffafc21937a32dd055f1df5c28d
change-id: 20250430-misc-test-fixup-90c5afce1d14

Best regards,
-- 
Thadeu Lima de Souza Cascardo <cascardo@...lia.com>