linux-kernel - Re: [PATCH v3 0/5] NMI warning and debug improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fXDriX5ipdvierw5VMTBUp-Q+97Xi5peaTmabe=Gp1BMw@mail.gmail.com>
Date: Tue, 29 Apr 2025 17:24:19 -0700
From: Ian Rogers <irogers@...gle.com>
To: "Liang, Kan" <kan.liang@...ux.intel.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Howard Chu <howardchu95@...il.com>, 
	Dominique Martinet <asmadeus@...ewreck.org>, Levi Yun <yeoreum.yun@....com>, 
	"Dr. David Alan Gilbert" <linux@...blig.org>, Andi Kleen <ak@...ux.intel.com>, 
	James Clark <james.clark@...aro.org>, Weilin Wang <weilin.wang@...el.com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/5] NMI warning and debug improvements

On Wed, Apr 2, 2025 at 1:33 PM Liang, Kan <kan.liang@...ux.intel.com> wrote:
>
> On 2025-04-02 4:15 p.m., Ian Rogers wrote:
> > The NMI warning wouldn't fire even if all the events were for one PMU
> > type. Remove a nearby, and no longer useful, mixed hardware event
> > group function. Improve the evlist to string function and dump it in
> > verbose mode after the reordered events warning.
> >
> > As commonly happens legacy events like instructions will be uniquified
> > to hybrid events like cpu_core/instructions/, even though the
> > encodings differ. To make this correct either:
> > https://lore.kernel.org/lkml/20250312211623.2495798-1-irogers@google.com/
> > or:
> > https://lore.kernel.org/linux-perf-users/20250109222109.567031-1-irogers@google.com/
> > needs merging.
> >
> > v3: Increase the verbose dump length from 1024 to 2048 as requested by
> >     Kan Liang.
> >
> > v2: Rename evlist__has_hybrid to evlist__has_hybrid_pmus and add a
> >     max_length parameter to evlist__format_evsels as suggested by Kan
> >     Liang.
> >
> > Ian Rogers (5):
> >   perf stat: Better hybrid support for the NMI watchdog warning
> >   perf stat: Remove print_mixed_hw_group_error
> >   perf evlist: Refactor evlist__scnprintf_evsels
> >   perf evlist: Add groups to evlist__format_evsels
> >   perf parse-events: Add debug dump of evlist if reordered
>
> Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>

Ping. The v3 patch series (this series) is here:
https://lore.kernel.org/lkml/20250402201549.4090305-1-irogers@google.com/

Thanks,
Ian

> Thanks,
> Kan
>
> >
> >  tools/perf/builtin-record.c    |  9 ++++---
> >  tools/perf/util/evlist.c       | 34 ++++++++++++++++-------
> >  tools/perf/util/evlist.h       |  3 ++-
> >  tools/perf/util/parse-events.c | 16 ++++++++---
> >  tools/perf/util/stat-display.c | 49 +++++++++++-----------------------
> >  tools/perf/util/stat.h         |  1 -
> >  6 files changed, 60 insertions(+), 52 deletions(-)
> >
>