Message-ID: <20250430184214.0b53dc6b@booty>
Date: Wed, 30 Apr 2025 18:42:14 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Doug Anderson <dianders@...omium.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
 <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Jagan Teki
 <jagan@...rulasolutions.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Chun-Kuang Hu
 <chunkuang.hu@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>, Anusha
 Srivatsa <asrivats@...hat.com>, Paul Kocialkowski <paulk@...-base.io>,
 Dmitry Baryshkov <lumag@...nel.org>, Hui Pu <Hui.Pu@...ealthcare.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 dri-devel@...ts.freedesktop.org, asahi@...ts.linux.dev,
 linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-amlogic@...ts.infradead.org,
 linux-renesas-soc@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 linux-samsung-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 freedreno@...ts.freedesktop.org, linux-stm32@...md-mailman.stormreply.com,
 Adam Ford <aford173@...il.com>, Adrien Grassein
 <adrien.grassein@...il.com>, Aleksandr Mishin <amishin@...rgos.ru>, Andy
 Yan <andy.yan@...k-chips.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Benson Leung
 <bleung@...omium.org>, Biju Das <biju.das.jz@...renesas.com>, Christoph
 Fritz <chf.fritz@...glemail.com>, Cristian Ciocaltea
 <cristian.ciocaltea@...labora.com>, Detlev Casanova
 <detlev.casanova@...labora.com>, Dharma Balasubiramani
 <dharma.b@...rochip.com>, Guenter Roeck <groeck@...omium.org>, Heiko
 Stuebner <heiko@...ech.de>, Jani Nikula <jani.nikula@...el.com>, Janne
 Grunau <j@...nau.net>, Jerome Brunet <jbrunet@...libre.com>, Jesse Van
 Gavere <jesseevg@...il.com>, Kevin Hilman <khilman@...libre.com>, Kieran
 Bingham <kieran.bingham+renesas@...asonboard.com>, Liu Ying
 <victor.liu@....com>, Manikandan Muralidharan <manikandan.m@...rochip.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Matthias Brugger
 <matthias.bgg@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, Phong LE
 <ple@...libre.com>, Sasha Finkelstein <fnkl.kernel@...il.com>, Sugar Zhang
 <sugar.zhang@...k-chips.com>, Sui Jingfeng <sui.jingfeng@...ux.dev>, Tomi
 Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, Vitalii Mordan
 <mordan@...ras.ru>
Subject: Re: [PATCH v2 01/34] drm: convert many bridge drivers from
 devm_kzalloc() to devm_drm_bridge_alloc() API

Hello Doug,

On Wed, 30 Apr 2025 08:51:52 -0700
Doug Anderson <dianders@...omium.org> wrote:

> Hi,
> 
> On Wed, Apr 30, 2025 at 3:36 AM Luca Ceresoli <luca.ceresoli@...tlin.com> wrote:
> >
> > Hello Doug,
> >
> > On Mon, 28 Apr 2025 13:59:50 -0700
> > Doug Anderson <dianders@...omium.org> wrote:
> >
> > [...]
> >  
> > > Reviewed-by: Douglas Anderson <dianders@...omium.org> # parade-ps8640
> > > Tested-by: Douglas Anderson <dianders@...omium.org> # parade-ps8640  
> >
> > Thank you for your review!
> >
> > However I'll be sending v3 with some differences w.r.t. v2, in order to
> > fix the 3 bugs reported by Andy Yan plus a similar one I spotted. The
> > fix just is replacing PTR_ERR() with ERR_CAST() in the 4 cases where the
> > involved function is returning a pointer instead of an int.
> >
> > Your review/test tags appear global to the whole patch, thus being the
> > patch different I think I cannot include your tags in v3.
> >
> > Let me know if you think I should do differently.
> >
> > Sorry about that.  
> 
> It's fine if you want to drop my tag. I didn't have time to review the
> whole thing but I felt like I should at least review the drivers I'm
> signed up as a reviewer for. That being said, I'm not counting tags or
> anything so I'm not offended if they're dropped.
> 
> My understanding is that the hashtag at the end is at least a
> semi-standard way to say that my tag only applies to a small part of
> the patch, so it seems like it would be OK to carry it, though...

Oh dear. I was so stupid. I had not seen the comment in your tag
lines... :-|

So it's fine, I'll keep your tags as the parade driver is not modified
in v3.

Sorry about the noise.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Powered by blists - more mailing lists