linux-kernel - Re: [PATCH net-next] xdp: add xdp_skb_reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6a8625c-9d20-48eb-b894-7bd6673a16d3@iogearbox.net>
Date: Wed, 30 Apr 2025 20:40:47 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Jon Kohler <jon@...anix.com>, Jason Wang <jasowang@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Alexei Starovoitov <ast@...nel.org>, Jesper Dangaard Brouer
 <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH net-next] xdp: add xdp_skb_reserve_put helper

On 4/30/25 8:25 PM, Willem de Bruijn wrote:
> Jon Kohler wrote:
>> Add helper for calling skb_{put|reserve} to reduce repetitive pattern
>> across various drivers.
>>
>> Plumb into tap and tun to start.
>>
>> No functional change intended.
>>
>> Signed-off-by: Jon Kohler <jon@...anix.com>
>> ---
>>   drivers/net/tap.c | 3 +--
>>   drivers/net/tun.c | 3 +--
>>   include/net/xdp.h | 8 ++++++++
>>   net/core/xdp.c    | 3 +--
>>   4 files changed, 11 insertions(+), 6 deletions(-)
> 
> Subjective, but I prefer the existing code. I understand what
> skb_reserve and skb_put do. While xdp_skb_reserve_put adds a layer of
> indirection that I'd have to follow.
> 
> Sometimes deduplication makes sense, sometimes the indirection adds
> more mental load than it's worth. In this case the code savings are
> small. As said, subjective. Happy to hear other opinions.

+1, agree with Willem