linux-kernel - Re: [PATCH v2 3/3] drm/msm/hdmi: use new helper for ACR tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd88b992-5d71-495f-a0cc-8ebc07544117@quicinc.com>
Date: Tue, 29 Apr 2025 18:03:06 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Rob Clark <robdclark@...il.com>, Sean Paul
	<sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        "Dave
 Stevenson" <dave.stevenson@...pberrypi.com>,
        Maíra Canal
	<mcanal@...lia.com>,
        Raspberry Pi Kernel Maintenance
	<kernel-list@...pberrypi.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        "Neil
 Armstrong" <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman
	<jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        "Dmitry
 Baryshkov" <lumag@...nel.org>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <freedreno@...ts.freedesktop.org>
Subject: Re: [PATCH v2 3/3] drm/msm/hdmi: use new helper for ACR tables



On 4/8/2025 6:54 AM, Dmitry Baryshkov wrote:
> Use new drm_hdmi_acr_get_n_cts() helper instead of hand-coding the
> tables. Instead of storing the rate 'index', store the audio sample rate
> in hdmi->audio.rate, removing the need for even more defines.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>   drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 107 +++-------------------------------
>   1 file changed, 9 insertions(+), 98 deletions(-)
> 

LGTM,

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>