linux-kernel - Re: [PATCH 2/2] mm/gup: Remove page_folio() in memfd_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55736622-b0fa-4ec6-ba47-09fa5c34c6c5@redhat.com>
Date: Wed, 30 Apr 2025 23:49:23 +0200
From: David Hildenbrand <david@...hat.com>
To: "Vishal Moola (Oracle)" <vishal.moola@...il.com>, linux-mm@...ck.org
Cc: linux-kernel@...r.kernel.org, Vivek Kasireddy
 <vivek.kasireddy@...el.com>, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] mm/gup: Remove page_folio() in memfd_pin_folios()

On 30.04.25 03:00, Vishal Moola (Oracle) wrote:
> We can get the folio directly from the folio batch, so remove the
> unnecessary page_folio() call.
> 
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@...il.com>
> ---
>   mm/gup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 1fb8f3b9a493..795fd94f379d 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -3640,7 +3640,7 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end,
>   			}
>   
>   			for (i = 0; i < nr_found; i++) {
> -				folio = page_folio(&fbatch.folios[i]->page);
> +				folio = fbatch.folios[i];
>   
>   				if (try_grab_folio(folio, 1, FOLL_PIN)) {
>   					folio_batch_release(&fbatch);

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb