linux-kernel - Re: [PATCH v3 2/3] alarmtimer: remove dead return value in clock2alarm()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANDhNCqgQ_c3_fsUcUcuUoiUrHRh267PiCSvb_XXU5O2rP8R5Q@mail.gmail.com>
Date: Wed, 30 Apr 2025 15:14:10 -0700
From: John Stultz <jstultz@...gle.com>
To: Su Hui <suhui@...china.com>
Cc: tglx@...utronix.de, sboyd@...nel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v3 2/3] alarmtimer: remove dead return value in clock2alarm()

On Tue, Apr 29, 2025 at 8:27 PM Su Hui <suhui@...china.com> wrote:
>
> 'clockid' only can be ALARM_REALTIME and ALARM_BOOTTIME. It's impossible
> to return -1 and callers never check the value of -1.
>
> Only alarm_clock_get_timespec(), alarm_clock_get_ktime(),
> alarm_timer_create() and alarm_timer_nsleep() call clock2alarm(). These
> callers using clockid_to_kclock() to get 'struct k_clock', this ensures
> clock2alarm() never returns -1.
>
> Remove the impossible -1 return value, and add a warn to be aware of any
> misuse of this function.
>
> Signed-off-by: Su Hui <suhui@...china.com>

Acked-by: John Stultz <jstultz@...gle.com>