linux-kernel - Re: [PATCH v2 sched_ext/for-6.16] sched_ext: Add RCU protection to scx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aBKmxlDdt6tmySKV@slm.duckdns.org>
Date: Wed, 30 Apr 2025 12:40:06 -1000
From: Tejun Heo <tj@...nel.org>
To: Andrea Righi <arighi@...dia.com>
Cc: David Vernet <void@...ifault.com>, Changwoo Min <changwoo@...lia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 sched_ext/for-6.16] sched_ext: Add RCU protection to
 scx_root in DSQ iterator

On Wed, Apr 30, 2025 at 10:21:56PM +0200, Andrea Righi wrote:
> Using a DSQ iterators from a timer callback can trigger the following
> lockdep splat when accessing scx_root:
> 
>  =============================
>  WARNING: suspicious RCU usage
>  6.14.0-virtme #1 Not tainted
>  -----------------------------
>  kernel/sched/ext.c:6907 suspicious rcu_dereference_check() usage!
> 
>  other info that might help us debug this:
> 
>  rcu_scheduler_active = 2, debug_locks = 1
>  no locks held by swapper/0/0.
> 
>  stack backtrace:
>  CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.14.0-virtme #1 PREEMPT(full)
>  Sched_ext: tickless (enabled+all)
>  Call Trace:
>  <IRQ>
>  dump_stack_lvl+0x6f/0xb0
>  lockdep_rcu_suspicious.cold+0x4e/0xa3
>  bpf_iter_scx_dsq_new+0xb1/0xd0
>  bpf_prog_63f4fd1bccc101e7_dispatch_cpu+0x3e/0x156
>  bpf_prog_8320d4217989178c_dispatch_all_cpus+0x153/0x1b6
>  bpf_prog_97f847d871513f95_sched_timerfn+0x4c/0x264
>  ? hrtimer_run_softirq+0x4f/0xd0
>  bpf_timer_cb+0x7a/0x140
>  __hrtimer_run_queues+0x1f9/0x3a0
>  hrtimer_run_softirq+0x8c/0xd0
>  handle_softirqs+0xd3/0x3d0
>  __irq_exit_rcu+0x9a/0xc0
>  irq_exit_rcu+0xe/0x20
>  sysvec_apic_timer_interrupt+0x73/0x80
> 
> Add a proper dereference check to explicitly validate RCU-safe access to
> scx_root from rcu_read_lock() contexts and also from contexts that hold
> rcu_read_lock_bh(), such as timer callbacks.
> 
> Fixes: cdf5a6faa8cf0 ("sched_ext: Move dsq_hash into scx_sched")
> Signed-off-by: Andrea Righi <arighi@...dia.com>

Applied to sched_ext/for-6.16.

Thanks.

-- 
tejun