linux-kernel - Re: [PATCH v6 5/6] platform/x86: Add Lenovo WMI Gamezone Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F54435E0-B3F5-4F99-9184-EE4D8D54DBD6@gmail.com>
Date: Tue, 29 Apr 2025 20:26:20 -0700
From: "Derek J. Clark" <derekjohn.clark@...il.com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>, Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Armin Wolf <W_Armin@....de>, Jonathan Corbet <corbet@....net>,
 Mario Limonciello <superm1@...nel.org>, Luke Jones <luke@...nes.dev>,
 Xino Ni <nijs1@...ovo.com>, Zhixin Zhang <zhangzx36@...ovo.com>,
 Mia Shao <shaohz1@...ovo.com>, Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 "Cody T . -H . Chiu" <codyit@...il.com>, John Martens <johnfanv2@...il.com>,
 platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 5/6] platform/x86: Add Lenovo WMI Gamezone Driver

On April 28, 2025 9:39:55 PM PDT, ALOK TIWARI <alok.a.tiwari@...cle.com> wrote:
>
>
>On 28-04-2025 06:48, Derek J. Clark wrote:
>> + * Determine if the extreme thermal mode is supported by the hardware.
>> + * Anything version 5 or lower does not. For devices wuth a version 6 or
>
>typo wuth
>
>> + * greater do a DMI check, as some devices report a version that supports
>> + * extreme mode but have an incomplete entry in the BIOS. To ensure this
>> + * cannot be set, quirk them to prevent assignment.
>> + *
>> + * Return: int.
>
>The function returns int.
>But logically it's returning boolean false, true

I may have overdone it by removing all bools after the v5 review as I interpreted Ilpo's comment to mean I shouldn't return any bool c types. I'll wait for them to weigh in before changing this back.

>> + */
>> +static int lwmi_gz_extreme_supported(int profile_support_ver)
>> +{
>> +	const struct dmi_system_id *dmi_id;
>> +	struct quirk_entry *quirks;
>> +
>> +	if (profile_support_ver < 6)
>> +		return false;
>> +
>> +	dmi_id = dmi_first_match(fwbug_list);
>> +	if (!dmi_id)
>> +		return true;
>> +
>> +	quirks = dmi_id->driver_data;
>> +	return quirks->extreme_supported;
>> +}
>
>Thank,
>Alok

Thanks,
- Derek