linux-kernel - Re: [PATCH 2/3] clk: qcom: camcc-sc8180x: Add SC8180X camera clock controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6075d01-1bca-48fb-b3f1-4a1b35c63ec5@quicinc.com>
Date: Wed, 30 Apr 2025 10:32:33 +0530
From: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>
CC: Ajit Pandey <quic_ajipan@...cinc.com>,
        Imran Shaik
	<quic_imrashai@...cinc.com>,
        Taniya Das <quic_tdas@...cinc.com>,
        "Jagadeesh
 Kona" <quic_jkona@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] clk: qcom: camcc-sc8180x: Add SC8180X camera clock
 controller driver


On 4/26/2025 6:54 PM, Vladimir Zapolskiy wrote:
> On 4/22/25 08:42, Satya Priya Kakitapalli wrote:
>> Add support for the camera clock controller for camera clients to
>> be able to request for camcc clocks on SC8180X platform.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
>> ---
>>   drivers/clk/qcom/Kconfig         |   10 +
>>   drivers/clk/qcom/Makefile        |    1 +
>>   drivers/clk/qcom/camcc-sc8180x.c | 2896 
>> ++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 2907 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index 
>> 7d5dac26b244bfe785370033ad8ba49876d6627d..42b64e34b3fcc4bae7c559f34a34f9452307ae9a 
>> 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -900,6 +900,16 @@ config SDX_GCC_75
>>         Say Y if you want to use peripheral devices such as UART,
>>         SPI, I2C, USB, SD/eMMC, PCIe etc.
>>   +config SC_CAMCC_8180X
>> +    tristate "SC8180X Camera Clock Controller"
>> +    depends on ARM64 || COMPILE_TEST
>> +    select SC_GCC_8180X
>> +    help
>> +      Support for the camera clock controller on Qualcomm 
>> Technologies, Inc
>> +      SC8180X devices.
>> +      Say Y if you want to support camera devices and functionality 
>> such as
>> +      capturing pictures.
>> +
>>   config SM_CAMCC_4450
>>       tristate "SM4450 Camera Clock Controller"
>>       depends on ARM64 || COMPILE_TEST
>
> Please add a new config section preserving the alphanumerical order.
>
> The new section should be placed between SC_CAMCC_7280 and 
> SC_CAMCC_8280XP,
> like it's correctly done for the Makefile below.
>

Sure, will fix it. Thanks.


> After fixing it:
>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
>
> -- 
> Best wishes,
> Vladimir