linux-kernel - Re: [PATCH] ksmbd: fix memory leak in parse_lease

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9q4Ax-6rwOzEooWpGJkonw1mjO_TKgMmB8Em+XR7zp_g@mail.gmail.com>
Date: Wed, 30 Apr 2025 14:43:10 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Wang Zhaolong <wangzhaolong1@...wei.com>
Cc: smfrench@...il.com, norbert@...ensec.com, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com, 
	chengzhihao1@...wei.com
Subject: Re: [PATCH] ksmbd: fix memory leak in parse_lease_state()

On Wed, Apr 30, 2025 at 12:16 PM Wang Zhaolong <wangzhaolong1@...wei.com> wrote:
>
> The previous patch that added bounds check for create lease context
> introduced a memory leak. When the bounds check fails, the function
> returns NULL without freeing the previously allocated lease_ctx_info
> structure.
>
> This patch fixes the issue by adding kfree(lreq) before returning NULL
> in both boundary check cases.
>
> Fixes: bab703ed8472 ("ksmbd: add bounds check for create lease context")
> Signed-off-by: Wang Zhaolong <wangzhaolong1@...wei.com>
Applied it to #ksmbd-for-next-next.
Thanks!