linux-kernel - Re: [PATCH] nvme: select tls config when tcp tls is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b39f8a89-29ce-4888-b639-7dae108bfd53@suse.de>
Date: Wed, 30 Apr 2025 08:12:35 +0200
From: Hannes Reinecke <hare@...e.de>
To: Alistair Francis <alistair23@...il.com>, hch@....de, sagi@...mberg.me,
 kch@...dia.com, linux-nvme@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH] nvme: select tls config when tcp tls is enabled

On 4/30/25 00:40, Alistair Francis wrote:
> Ensure that TLS support is enabled in the kernel when
> NVME_TCP_TLSS is enabled. This allows TLS secure channels to be
> used out of the box.
> 
> Fixes: be8e82caa68 ("nvme-tcp: enable TLS handshake upcall")
> Signed-off-by: Alistair Francis <alistair.francis@....com>
> ---
>   drivers/nvme/host/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index d47dfa80fb95..4d64b6935bb9 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -102,6 +102,7 @@ config NVME_TCP_TLS
>   	depends on NVME_TCP
>   	select NET_HANDSHAKE
>   	select KEYS
> +	select TLS
>   	help
>   	  Enables TLS encryption for NVMe TCP using the netlink handshake API.
>   
I would have folded it into the previous patch.

Otherwise:

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich