linux-kernel - Re: [PATCH v4 4/4] perf test amd ibs: Add sample period unit test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eeae0c3b-7f9d-4dfe-bf98-2c4f79f96187@amd.com>
Date: Wed, 30 Apr 2025 12:03:40 +0530
From: Ravi Bangoria <ravi.bangoria@....com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Ingo Molnar <mingo@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
 Peter Zijlstra <peterz@...radead.org>, Joe Mario <jmario@...hat.com>,
 Stephane Eranian <eranian@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Ian Rogers <irogers@...gle.com>, Kan Liang <kan.liang@...ux.intel.com>,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
 Santosh Shukla <santosh.shukla@....com>,
 Ananth Narayan <ananth.narayan@....com>, Sandipan Das
 <sandipan.das@....com>, Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH v4 4/4] perf test amd ibs: Add sample period unit test

On 30-Apr-25 2:25 AM, Arnaldo Carvalho de Melo wrote:
> On Tue, Apr 29, 2025 at 03:59:38AM +0000, Ravi Bangoria wrote:
>> IBS Fetch and IBS Op PMUs has various constraints on supported sample
>> periods. Add perf unit tests to test those.
>>
>> Running it in parallel with other tests causes intermittent failures.
>> Mark it exclusive to force it to run sequentially. Sample output on a
>> Zen5 machine:
> 
> I've applied the series and will test it now, but found some problems
> when building in some non-glibc systems, namely the use of PAGE_SIZE,
> that is used in libc headers, even in glibc, its just that in glibc we
> happen not to include that header where PAGE_SIZE gets redefined:
> 
> ⬢ [acme@...lbx perf-tools-next]$ grep PAGE_SIZE /usr/include/sys/*.h
> /usr/include/sys/user.h:#define PAGE_SIZE		(1UL << PAGE_SHIFT)
> /usr/include/sys/user.h:#define PAGE_MASK		(~(PAGE_SIZE-1))
> /usr/include/sys/user.h:#define NBPG			PAGE_SIZE
> ⬢ [acme@...lbx perf-tools-next]$
> 
> So I folded the following patch, see if it is acceptable and please ack.

Thanks for the fix Arnaldo. It LGTM.

Ravi