linux-kernel - Re: [PATCH v3 2/4] mm/hugetlb: Refactor unmap_hugepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aBHW2NJ95-HBORl3@localhost.localdomain>
Date: Wed, 30 Apr 2025 09:52:56 +0200
From: Oscar Salvador <osalvador@...e.de>
To: nifan.cxl@...il.com
Cc: muchun.song@...ux.dev, willy@...radead.org, mcgrof@...nel.org,
	a.manzanares@...sung.com, dave@...olabs.net,
	akpm@...ux-foundation.org, david@...hat.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Fan Ni <fan.ni@...sung.com>,
	Sidhartha Kumar <sidhartha.kumar@...cle.com>
Subject: Re: [PATCH v3 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to
 take folio instead of page

On Mon, Apr 28, 2025 at 10:11:45AM -0700, nifan.cxl@...il.com wrote:
> From: Fan Ni <fan.ni@...sung.com>
> 
> The function unmap_hugepage_range() has two kinds of users:
> 1) unmap_ref_private(), which passes in the head page of a folio.  Since
>    unmap_ref_private() already takes folio and there are no other uses
>    of the folio struct in the function, it is natural for
>    unmap_hugepage_range() to take folio also.
> 2) All other uses, which pass in NULL pointer.
> 
> In both cases, we can pass in folio. Refactor unmap_hugepage_range() to
> take folio.
> 
> Signed-off-by: Fan Ni <fan.ni@...sung.com>
> Reviewed-by: Muchun Song <muchun.song@...ux.dev>
> Reviewed-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>

Reviewed-by: Oscar Salvador <osalvador@...e.de>


-- 
Oscar Salvador
SUSE Labs