linux-kernel - Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e34ce09-1207-4dba-bff8-38c01cad9b78@linaro.org>
Date: Wed, 30 Apr 2025 10:19:13 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Johan Hovold <johan@...nel.org>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] media: qcom: camss: vfe: Stop spamming logs with
 version

On 30/04/2025 09:25, Johan Hovold wrote:
> On Tue, Apr 29, 2025 at 08:08:29PM +0200, Krzysztof Kozlowski wrote:
>> Camss drivers spam kernel dmesg with 64 useless messages during boot:
>>
>>   qcom-camss acb7000.isp: VFE:1 HW Version = 3.0.2
>>   qcom-camss acb7000.isp: VFE:2 HW Version = 2.4.0
>>
>> All of these messages are the same, so it makes no sense to print same
>> information 32 times.
> 
> It's even worse then that (several hundred messages during use) and I
> sent fixes for these regressions a few weeks ago:
> 
> 	https://lore.kernel.org/lkml/20250407104828.3833-1-johan+linaro@kernel.org/
> 	https://lore.kernel.org/lkml/20250407085125.21325-1-johan+linaro@kernel.org/

Oh damn...

I developed this on top of next, so already with your fixes included,
but - following standard kernel coding practice that drivers should be
silent on success - I think even debug messages are not needed here.

There is really no point in printing (even as debug) version of hw block
EVERY TIME I boot the hardware. It does not change, does it?

If anyone wants to know it and cannot deduce from compatible, then add
debugfs interface.


Best regards,
Krzysztof