[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <zpmfhi6fzg3zhwifpi2kmstn4soex4fvg5jhha2me73r76bhgo@j2bfwdza23xs>
Date: Wed, 30 Apr 2025 10:37:48 +0200
From: Richard Leitner <richard.leitner@...ux.dev>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Dave Stevenson <dave.stevenson@...pberrypi.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>, Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>, Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v3 3/9] media: v4l2-flash: add support for flash/strobe
duration
Hi Sakari,
thanks for your quick feedback!
On Wed, Apr 30, 2025 at 08:24:00AM +0000, Sakari Ailus wrote:
> Hi Richard,
>
> On Tue, Apr 29, 2025 at 02:59:08PM +0200, Richard Leitner wrote:
> > Add support for the new V4L2_CID_FLASH_DURATION control to the v4l2
> > flash led class.
> >
> > Signed-off-by: Richard Leitner <richard.leitner@...ux.dev>
> > ---
> > drivers/media/v4l2-core/v4l2-flash-led-class.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c
> > index 355595a0fefac72c2f6941a30fa430d37dbdccfe..963b549480f6eb3b9eb0d80696a764de7ffcc1a2 100644
> > --- a/drivers/media/v4l2-core/v4l2-flash-led-class.c
> > +++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c
> > @@ -298,6 +298,12 @@ static int v4l2_flash_s_ctrl(struct v4l2_ctrl *c)
> > * microamperes for flash intensity units.
> > */
> > return led_set_flash_brightness(fled_cdev, c->val);
> > + case V4L2_CID_FLASH_DURATION:
> > + /*
> > + * No conversion is needed as LED Flash class also uses
> > + * microseconds for flash duration units.
> > + */
> > + return led_set_flash_duration(fled_cdev, c->val);
> > }
> >
> > return -EINVAL;
> > @@ -424,6 +430,13 @@ static void __fill_ctrl_init_data(struct v4l2_flash *v4l2_flash,
> > ctrl_cfg->flags = V4L2_CTRL_FLAG_VOLATILE |
> > V4L2_CTRL_FLAG_EXECUTE_ON_WRITE;
> > }
> > +
> > + /* Init FLASH_DURATION ctrl data */
> > + if (has_flash_op(fled_cdev, timeout_set)) {
> > + ctrl_init_data[FLASH_DURATION].cid = V4L2_CID_FLASH_DURATION;
> > + ctrl_cfg = &ctrl_init_data[FLASH_DURATION].config;
> > + __lfs_to_v4l2_ctrl_config(&fled_cdev->duration, ctrl_cfg);
> > + ctrl_cfg->id = V4L2_CID_FLASH_DURATION;
>
> Has this been compile tested? :-)
Oooh... Damn. That's embarrasing. SORRY! There should have been at least
another '}' in this patch.... Seems I somehow messed up my last rebase.
Will fix that in v4. Sorry again :-/
>
> > }
> >
> > static int v4l2_flash_init_controls(struct v4l2_flash *v4l2_flash,
> >
>
> --
> Regards,
>
> Sakari Ailus
regards;rl
Powered by blists - more mailing lists