linux-kernel - Re: [PATCH v4 01/15] x86/msr: Add missing includes of <asm/msr.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c16677bd-ee63-4032-8825-7d2789dd7555@zytor.com>
Date: Wed, 30 Apr 2025 01:41:06 -0700
From: Xin Li <xin@...or.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kvm@...r.kernel.org,
        linux-perf-users@...r.kernel.org, linux-hyperv@...r.kernel.org,
        virtualization@...ts.linux.dev, linux-pm@...r.kernel.org,
        linux-edac@...r.kernel.org, xen-devel@...ts.xenproject.org,
        linux-acpi@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, platform-driver-x86@...r.kernel.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        acme@...nel.org, jgross@...e.com, andrew.cooper3@...rix.com,
        peterz@...radead.org, namhyung@...nel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        irogers@...gle.com, adrian.hunter@...el.com, kan.liang@...ux.intel.com,
        wei.liu@...nel.org, ajay.kaher@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, tony.luck@...el.com,
        pbonzini@...hat.com, vkuznets@...hat.com, seanjc@...gle.com,
        luto@...nel.org, boris.ostrovsky@...cle.com, kys@...rosoft.com,
        haiyangz@...rosoft.com, decui@...rosoft.com,
        dapeng1.mi@...ux.intel.com
Subject: Re: [PATCH v4 01/15] x86/msr: Add missing includes of <asm/msr.h>

On 4/29/2025 2:45 AM, Ilpo Järvinen wrote:
>>   arch/x86/events/msr.c                                         | 3 +++
>>   arch/x86/events/perf_event.h                                  | 1 +
>>   arch/x86/events/probe.c                                       | 2 ++
> Under arch/x86/events/ a few files seem to be missing the include?


Most C files in arch/x86/events/ include arch/x86/events/perf_event.h,
thus they don't need to include <asm/msr.h> directly once
arch/x86/events/perf_event.h includes <asm/msr.h>, and this patch does
that.


The following files include arch/x86/events/intel/uncore.h which 
includes arch/x86/events/perf_event.h, thus no change needed:
     arch/x86/events/intel/uncore.c
     arch/x86/events/intel/uncore_discovery.c
     arch/x86/events/intel/uncore_nhmex.c
     arch/x86/events/intel/uncore_snb.c
     arch/x86/events/intel/uncore_snbep.c

The following 2 files don't include arch/x86/events/perf_event.h so they
include <asm/msr.h> directly with this patch:
     arch/x86/events/msr.c
     arch/x86/events/probe.c

arch/x86/events/amd/uncore.c doesn't include
arch/x86/events/perf_event.h but includes <asm/msr.h> already.


So we are good in this directory, but it should be a separate patch with
the above explanation then.