linux-kernel - RE: [PATCH v2 3/4] clk: samsung: exynosautov920: Fix incorrect CLKS_NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04c801dbb9ac$17eb1f40$47c15dc0$@samsung.com>
Date: Wed, 30 Apr 2025 17:44:31 +0900
From: 손신 <shin.son@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>
Cc: "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>, "'Chanwoo Choi'"
	<cw00.choi@...sung.com>, "'Alim Akhtar'" <alim.akhtar@...sung.com>,
	"'Michael	Turquette'" <mturquette@...libre.com>, "'Stephen Boyd'"
	<sboyd@...nel.org>, "'Rob	Herring'" <robh@...nel.org>, "'Conor Dooley'"
	<conor+dt@...nel.org>, "'Sunyeal Hong'" <sunyeal.hong@...sung.com>,
	<linux-samsung-soc@...r.kernel.org>, <linux-clk@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 3/4] clk: samsung: exynosautov920: Fix incorrect
 CLKS_NR_CPUCL0 definition

Hello Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk@...nel.org]
> Sent: Wednesday, April 30, 2025 4:26 PM
> To: Shin Son <shin.son@...sung.com>
> Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>; Chanwoo Choi
> <cw00.choi@...sung.com>; Alim Akhtar <alim.akhtar@...sung.com>; Michael
> Turquette <mturquette@...libre.com>; Stephen Boyd <sboyd@...nel.org>; Rob
> Herring <robh@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Sunyeal
> Hong <sunyeal.hong@...sung.com>; linux-samsung-soc@...r.kernel.org; linux-
> clk@...r.kernel.org; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 3/4] clk: samsung: exynosautov920: Fix incorrect
> CLKS_NR_CPUCL0 definition
> 
> On Mon, Apr 28, 2025 at 08:35:16PM GMT, Shin Son wrote:
> > The CLKS_NR_CPUCL0 macro was incorrectly defined based on a wrong clock
> ID.
> > It mistakenly referenced CLK_DOUT_CLUSTER0_PERIPHCLK, which
> > corresponds to a cluster peripheral clock, not the last clock ID for
> CPUCL0 as intended.
> >
> > This patch corrects the definition to use CLK_DOUT_CPUCL0_NOCP + 1,
> 
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://protect2.fireeye.com/v1/url?k=2e90faf7-4f1befd2-2e9171b8-
> 74fe485cbff6-28bf0169b8fd9187&q=1&e=dfbde4e5-fe38-4140-aa45-
> b3362eb2dc00&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.17.1%2Fsource
> %2FDocumentation%2Fprocess%2Fsubmitting-patches.rst%23L95
> 
> > properly matching the last clock ID for CPUCL0 as intended.
> >
> > This error was due to confusion with the hardware diagram, and this
> > patch ensures that the number of clocks for CPUCL0 is correctly defined.
> 
> Fixes: 59636ec89c2c ("clk: samsung: exynosautov920: add cpucl0 clock
> support")
> 
> 
> And proper order - fixes are *ALWAYS* before new features.
> 
> Best regards,
> Krzysztof

Thank you for applying my patches.
I appreciate your feedback, and I’ll make sure to improve those parts in the future.

Have a great day.

Best regards,
Shin Son.