linux-kernel - Re: [PATCH] drivers: media: i2c: imx335: Fix frame size enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174600329094.1586992.9902010088598676539@ping.linuxembedded.co.uk>
Date: Wed, 30 Apr 2025 09:54:50 +0100
From: Kieran Bingham <kieran.bingham@...asonboard.com>
To: Sakari Ailus <sakari.ailus@....fi>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: media: i2c: imx335: Fix frame size enumeration

Quoting Sakari Ailus (2025-04-30 09:45:09)
> Hi Kieran,
> 
> On Wed, Apr 30, 2025 at 08:36:49AM +0100, Kieran Bingham wrote:
> > In commit cfa49ff0558a ("media: i2c: imx335: Support 2592x1940 10-bit
> > mode") the IMX335 driver was extended to support multiple output
> > bitdepth modes.
> > 
> > This incorrectly extended the frame size enumeration to check against
> > the supported mbus_codes array instead of the supported mode/frame
> > array. This has the unwanted side effect of reporting the currently
> > supported frame size 2592x1944 three times.
> > 
> > Fix the check accordingly to report a frame size for each supported
> > size, which is presently only a single entry.
> > 
> > Fixes: cfa49ff0558a ("media: i2c: imx335: Support 2592x1940 10-bit mode")
> > Signed-off-by: Kieran Bingham <kieran.bingham@...asonboard.com>
> 
> Thanks for the patch.
> 
> Cc: stable is required these days with Fixes: tag, I've added it this time.


I didn't know that. I thought stable tree picked up from the fixes tags.
(Or I remember there was some AI system that was picking them out too?)

I'll see if I can automate/add that to my fixes helper.

Does it need to be in this format?

Cc: stable@...r.kernel.org      # 6.8

--
Kieran


> 
> -- 
> Sakari Ailus