linux-kernel - Re: [PATCH] ovl: Fix nested backing file paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegv=CFjkAXLM26vFc0prGJ18aVeO3j_0LQSh290DQZn_+g@mail.gmail.com>
Date: Wed, 30 Apr 2025 11:08:06 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: André Almeida <andrealmeid@...lia.com>
Cc: Amir Goldstein <amir73il@...il.com>, linux-unionfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-dev@...lia.com, 
	John Schoenick <johns@...vesoftware.com>
Subject: Re: [PATCH] ovl: Fix nested backing file paths

On Tue, 29 Apr 2025 at 20:39, André Almeida <andrealmeid@...lia.com> wrote:
>
> When the lowerdir of an overlayfs is a merged directory of another
> overlayfs, ovl_open_realfile() will fail to open the real file and point
> to a lower dentry copy, without the proper parent path. After this,
> d_path() will then display the path incorrectly as if the file is placed
> in the root directory.
>
> This bug can be triggered with the following setup:
>
>  mkdir -p ovl-A/lower ovl-A/upper ovl-A/merge ovl-A/work
>  mkdir -p ovl-B/upper ovl-B/merge ovl-B/work
>
>  cp /bin/cat ovl-A/lower/
>
>  mount -t overlay overlay -o \
>  lowerdir=ovl-A/lower,upperdir=ovl-A/upper,workdir=ovl-A/work \
>  ovl-A/merge
>
>  mount -t overlay overlay -o \
>  lowerdir=ovl-A/merge,upperdir=ovl-B/upper,workdir=ovl-B/work \
>  ovl-B/merge
>
>  ovl-A/merge/cat /proc/self/maps | grep --color cat
>  ovl-B/merge/cat /proc/self/maps | grep --color cat
>
> The first cat will correctly show `/ovl-A/merge/cat`, while the second
> one shows just `/cat`.
>
> To fix that, uses file_user_path() inside of backing_file_open() to get
> the correct file path for the dentry.
>
> Co-developed-by: John Schoenick <johns@...vesoftware.com>
> Signed-off-by: John Schoenick <johns@...vesoftware.com>
> Signed-off-by: André Almeida <andrealmeid@...lia.com>

Perfect, thanks!

Added these:

    Fixes: def3ae83da02 ("fs: store real path instead of fake path in
backing file f_path")
    Cc: <stable@...r.kernel.org> # v6.7

and pushed to ovl-next.

Thanks,
Miklos