linux-kernel - Re: [PATCH v8 0/5] Add Loongson Security Engine chip driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f2a34ce-3e4b-7dda-4835-34bfd0ef60fc@loongson.cn>
Date: Wed, 30 Apr 2025 17:10:04 +0800
From: Qunqin Zhao <zhaoqunqin@...ngson.cn>
To: Lee Jones <lee@...nel.org>, Huacai Chen <chenhuacai@...nel.org>,
 Herbert Xu <herbert@...dor.apana.org.au>, jarkko@...nel.org
Cc: davem@...emloft.net, peterhuewe@....de, linux-kernel@...r.kernel.org,
 loongarch@...ts.linux.dev, linux-crypto@...r.kernel.org, jgg@...pe.ca,
 linux-integrity@...r.kernel.org, pmenzel@...gen.mpg.de
Subject: Re: [PATCH v8 0/5] Add Loongson Security Engine chip driver


在 2025/4/30 下午4:58, Lee Jones 写道:
> On Wed, 30 Apr 2025, Huacai Chen wrote:
>
>> On Wed, Apr 30, 2025 at 4:47 PM Qunqin Zhao <zhaoqunqin@...ngson.cn> wrote:
>>>
>>> 在 2025/4/30 下午4:18, Herbert Xu 写道:
>>>> On Wed, Apr 30, 2025 at 04:14:40PM +0800, Qunqin Zhao wrote:
>>>>> Sorry to bother you, may i ask is it fine to move  the Security Engine base
>>>>> driver[Patch v8 1/5] to drivers/crypto ?
>>>>>
>>>>> The base driver uses MFD  interface  to register child device(tpm, rng) , as
>>>>> done in
>>>>>
>>>>> "drivers/iio/common/ssp_sensors/ssp_dev.c" and
>>>>> "drivers/firmware/xilinx/zynqmp.c".
>>>>>
>>>>> Thank you, and I look forward to hearing from you.
>>>> I don't mind at this point in time.  But if this driver were to
>>>> develop features way outside of the Crypto API in future then I
>>>> may change my mind.
>>> Hi, Herbert, thanks for your reply.
>>>
>>> In future it just add child platform devices  name(sm2, sm3, sm4) to
>>> "struct  mfd_cell engines".
>>>
>>>
>>> Hi, Huaci
>>>
>>> Let's go via Herbert's crypto tree for the base driver patch under
>>> drivers/crypto/loongson/,
>>>
>>> What do you think of it?
>> In my opinion drivers/mfd is better, because another user is in
>> drivers/char rather than drivers/crypto.
>>
>> But if moving to drivers/crypto is what Lee Jones wants, then everything is OK.
> You can move the driver, but then you must not reference or use the MFD API.

Then looks like i should move it back to drivers/mfd,  will do that in 
next revision.

Thank you very much for everyone's replies.

BR, Qunqin.

>