[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aBHpR18KE2l6VJsC@tom-desktop>
Date: Wed, 30 Apr 2025 11:11:35 +0200
From: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
Biju Das <biju.das.jz@...renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v2 1/2] media: renesas: rzg2l-cru: Simplify FIFO empty
check
On Tue, Apr 29, 2025 at 10:16:08AM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Collapse FIFO empty helper into a single return statement by removing the
> redundant `if (amnfifopntr_w == amnfifopntr_r_y) return true;` path. Make
> `rzg2l_fifo_empty()` directly return `amnfifopntr_w == amnfifopntr_r_y`
> to improve readability without changing behavior.
>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/all/aAtQThCibZCROETx@stanley.mountain/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
Tested-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
Thanks & Regards,
Tommaso
> ---
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 067c6af14e95..3d0810b3c35e 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -345,8 +345,6 @@ bool rzg2l_fifo_empty(struct rzg2l_cru_dev *cru)
> amnfifopntr_w = amnfifopntr & AMnFIFOPNTR_FIFOWPNTR;
> amnfifopntr_r_y =
> (amnfifopntr & AMnFIFOPNTR_FIFORPNTR_Y) >> 16;
> - if (amnfifopntr_w == amnfifopntr_r_y)
> - return true;
>
> return amnfifopntr_w == amnfifopntr_r_y;
> }
> --
> 2.49.0
>
>
Powered by blists - more mailing lists