linux-kernel - Re: [PATCH v2 0/3] rust: add `UnsafePinned` type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D9JVLYZLBG75.2RG8ZG8Q48HNB@kernel.org>
Date: Wed, 30 Apr 2025 11:46:31 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Christian Schrefl" <chrisi.schrefl@...il.com>, "Sky" <sky@...9.dev>,
 "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>,
 "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <benno.lossin@...ton.me>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 "Danilo Krummrich" <dakr@...nel.org>, Gerald Wisböck
 <gerald.wisboeck@...ther.ink>
Cc: <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v2 0/3] rust: add `UnsafePinned` type

On Wed Apr 30, 2025 at 10:36 AM CEST, Christian Schrefl wrote:
> This version now only has the kernel implementation without the
> config flag for using the upstream version. Additionally now
> commits for using `UnsafePinned` in `Opaque` were added.
>
> Checkpatch warns about `rust/kernel/types/unsafe_pinned.rs`
> missing a MAINTAINERS entry, I don't think that is necessary since it
> will be part of the `RUST` entry anyways (from what I understand).

That is correct, it will be part of RUST. AFAIK checkpatch always warns
when a new file is added, but I could be wrong.

---
Cheers,
Benno

> Once this has had some time to review I'll rebase my `miscdevice`
> patches [0] on top of this.
>
> This patchset depends on the `pin-init` sync for v6.16 [1].
>
> Link: https://lore.kernel.org/rust-for-linux/20250131-b4-rust_miscdevice_registrationdata-v2-0-588f1e6cfabe@gmail.com/ [0]
> Link: https://lore.kernel.org/rust-for-linux/20250421221728.528089-1-benno.lossin@proton.me [1]
>
> Signed-off-by: Christian Schrefl <chrisi.schrefl@...il.com>
> ---
> Changes in v2:
> - Expanded `UnsafePinned` documentation to describe differences
>     with upstream rust implementation.
> - Removed config flag for using upstream `UnsafePinned` type.
> - Add patch implementing `Wrapper` for `Opaque`
> - Add patch for using `UnsafePinned` internally in `Opaque`
> - Link to v1: https://lore.kernel.org/r/20250418-rust_unsafe_pinned-v1-1-c4c7558399f8@gmail.com
>
> ---
> Christian Schrefl (3):
>       rust: add UnsafePinned type
>       rust: implement `Wrapper<T>` for `Opaque<T>`
>       rust: use `UnsafePinned` in the implementation of `Opaque`
>
>  init/Kconfig                       |   3 +
>  rust/kernel/lib.rs                 |   1 +
>  rust/kernel/revocable.rs           |   2 +
>  rust/kernel/types.rs               |  42 +++++++-------
>  rust/kernel/types/unsafe_pinned.rs | 115 +++++++++++++++++++++++++++++++++++++
>  5 files changed, 143 insertions(+), 20 deletions(-)
> ---
> base-commit: 39051adb070432b283e6c11b2b24937281b9f97f
> change-id: 20250418-rust_unsafe_pinned-891dce27418d
> prerequisite-message-id: <20250421221728.528089-1-benno.lossin@...ton.me>
> prerequisite-patch-id: dcf79c049766e66eda0377b225bb441edefcdfe4
> prerequisite-patch-id: 0a078ba4989327e90317f882fa42a387bb7594a0
> prerequisite-patch-id: d5182c6fc3e3b2f255001334b5da9d5c5b7b29ed
> prerequisite-patch-id: 016806607094f0f403000ec455db9ea79e538bf6
> prerequisite-patch-id: 368bea523f3b3e14f1dd599343475e0b166fad37
> prerequisite-patch-id: 526054a8a8871d1dd5f376b7ab6aa5542b481b70
> prerequisite-patch-id: a691b331bc3200287413e6423b8cc3e9cbb177e0
> prerequisite-patch-id: 5afb38f41b18408fef4d3abc5750c09a67b2d34e
>
> Best regards,