linux-kernel - Re: [PATCH v2 10/22] iommufd/viommmu: Add IOMMUFD_CMD_VCMDQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91d1df7e-b136-4024-a1f2-20b1374ede40@amd.com>
Date: Wed, 30 Apr 2025 15:51:25 +0530
From: Vasant Hegde <vasant.hegde@....com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: jgg@...dia.com, kevin.tian@...el.com, corbet@....net, will@...nel.org,
 bagasdotme@...il.com, robin.murphy@....com, joro@...tes.org,
 thierry.reding@...il.com, vdumpa@...dia.com, jonathanh@...dia.com,
 shuah@...nel.org, jsnitsel@...hat.com, nathan@...nel.org,
 peterz@...radead.org, yi.l.liu@...el.com, mshavit@...gle.com,
 praan@...gle.com, zhangzekun11@...wei.com, iommu@...ts.linux.dev,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
 linux-kselftest@...r.kernel.org, patches@...ts.linux.dev, mochs@...dia.com,
 alok.a.tiwari@...cle.com,
 Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Subject: Re: [PATCH v2 10/22] iommufd/viommmu: Add IOMMUFD_CMD_VCMDQ_ALLOC
 ioctl



On 4/30/2025 1:31 PM, Nicolin Chen wrote:
> On Wed, Apr 30, 2025 at 09:52:09AM +0530, Vasant Hegde wrote:
>>>>> Will the hardware replace the physical device ID in the event with
>>>>> the virtual device ID when injecting the event to a guest event/PPR
>>>>> queue? 
>>>>> If so, yea, I think you can define them separately using the> vCMDQ
>>>> infrastructures:
>>>>>  - IOMMU_VCMDQ_TYPE_AMD_VIOMMU_CMDBUF
>>>>>  - IOMMU_VCMDQ_TYPE_AMD_VIOMMU_EVENTLOG
>>>>>  - IOMMU_VCMDQ_TYPE_AMD_VIOMMU_PPRLOG
>>>>> (@Kevin @Jason Hmm, in this case we might want to revert the naming
>>>>>  "vCMDQ" back to "vQEUEUE", once Vasant confirms.)
>>>
>>> I think I should rename IOMMUFD_OBJ_VCMDQ back to IOMMUFD_OBJ_VQUEUE
>>> since the same object fits three types of queue now in the AMD case.
>>
>> Makes sense.
>>
>> AMD architecture supports 5 buffers. In practice we have not implemented event
>> log  B / PPR Log B in Linux.
>>   Command buffer
>>   Event Log A / B
>>   PPR Log A / B
> 
> I think those A/B should be dual buffers of the same type?

Yes.



> 
> Anyway, I have renamed all the core "vCMDQ" back to "vQUEUE" in my
> local branch. Will send v3 in the next days.

Sure thanks.

-Vasant