linux-kernel - RE: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f6e01dbb9b1$d52519d0$7f6f4d70$@samsung.com>
Date: Wed, 30 Apr 2025 14:55:34 +0530
From: "Yashwant Varur" <yashwant.v@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <alim.akhtar@...sung.com>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc: <cs0617.lee@...sung.com>, <g.naidu@...sung.com>,
	<niyas.ahmed@...sung.com>
Subject: RE: [PATCH] arm64: dts: exynos: Added the ethernet pin
 configuration

Hi Krzysztof

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Tuesday, April 29, 2025 6:37 PM
> To: Yashwant Varur <yashwant.v@...sung.com>; robh@...nel.org;
> krzk+dt@...nel.org; conor+dt@...nel.org; alim.akhtar@...sung.com;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: cs0617.lee@...sung.com; g.naidu@...sung.com;
> niyas.ahmed@...sung.com
> Subject: Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration
> 
> On 29/04/2025 11:29, Yashwant Varur wrote:
> >
> > Please follow DTS coding style carefully. This applies to all commits you try to
> send from your downstream/vendor code.
> 
> 
> hm?
> 
Got the issue, coding style says
Node and property names can use only the following characters:
Lowercase characters: [a-z]
Digits: [0-9]
Dash: -
I was using underscore for node name.
> >>
> > Sure, thanks
> >
> > What is more important, I don't really understand why you are doing
> > this
> > - there is no user of these entries - and commit msg does not help here.
> >>
> > Understood, in v2 will add the Ethernet node as well.
> 
> I don't understand what is your reply here and what is quote. Use standard email
> style, not some mySingle or Outlook output. I suggest reading typical guidelines
> how to use email based workflows (kernel also has one).
> 

Looks like mailer was not configured properly, hope this time it is fine.
I am working on upstreaming Ethernet driver for exynosauto (which has a variant of STMMAC controller)
What I wanted to reply previously was, will add pin control, along with Ethernet node(which will consume the pincontrol) and
I realize that first dt-binding should go for this IP.
My plan is to send Ethernet driver along with Ethernet dtsi node as well.

> 
> Best regards,
> Krzysztof