linux-kernel - Re: [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <702f4def-7382-4d95-8b3d-c1c10c11f627@amd.com>
Date: Wed, 30 Apr 2025 16:02:36 +0530
From: Vasant Hegde <vasant.hegde@....com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] iommu: Cleanup comments for dev_enable/disable_feat

On 4/30/2025 8:22 AM, Lu Baolu wrote:
> The dev_enable/disable_feat ops have been removed by commit
> <f984fb09e60e> ("iommu: Remove iommu_dev_enable/disable_feature()").
> Cleanup the comments to make the code clean.
> 
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>

Reviewed-by: Vasant Hegde <vasant.hegde@....com>

-Vasant

> ---
>  include/linux/iommu.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 1785caee5977..36df38c2d3a9 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -590,8 +590,6 @@ iommu_copy_struct_from_full_user_array(void *kdst, size_t kdst_entry_size,
>   * @of_xlate: add OF master IDs to iommu grouping
>   * @is_attach_deferred: Check if domain attach should be deferred from iommu
>   *                      driver init to device driver init (default no)
> - * @dev_enable/disable_feat: per device entries to enable/disable
> - *                               iommu specific features.
>   * @page_response: handle page request response
>   * @def_domain_type: device default domain type, return value:
>   *		- IOMMU_DOMAIN_IDENTITY: must use an identity domain