linux-kernel - Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250430123651.37be3e38@booty>
Date: Wed, 30 Apr 2025 12:36:51 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: <Manikandan.M@...rochip.com>
Cc: <maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
 <tzimmermann@...e.de>, <airlied@...il.com>, <simona@...ll.ch>,
 <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
 <Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
 <jernej.skrabec@...il.com>, <jagan@...rulasolutions.com>,
 <shawnguo@...nel.org>, <s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
 <festevam@...il.com>, <dianders@...omium.org>, <chunkuang.hu@...nel.org>,
 <krzk@...nel.org>, <asrivats@...hat.com>, <paulk@...-base.io>,
 <lumag@...nel.org>, <Hui.Pu@...ealthcare.com>,
 <thomas.petazzoni@...tlin.com>, <dri-devel@...ts.freedesktop.org>,
 <asahi@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
 <chrome-platform@...ts.linux.dev>, <imx@...ts.linux.dev>,
 <linux-arm-kernel@...ts.infradead.org>,
 <linux-mediatek@...ts.infradead.org>, <linux-amlogic@...ts.infradead.org>,
 <linux-renesas-soc@...r.kernel.org>, <platform-driver-x86@...r.kernel.org>,
 <linux-samsung-soc@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
 <freedreno@...ts.freedesktop.org>,
 <linux-stm32@...md-mailman.stormreply.com>, <aford173@...il.com>,
 <adrien.grassein@...il.com>, <amishin@...rgos.ru>,
 <andy.yan@...k-chips.com>, <angelogioacchino.delregno@...labora.com>,
 <bleung@...omium.org>, <biju.das.jz@...renesas.com>,
 <chf.fritz@...glemail.com>, <cristian.ciocaltea@...labora.com>,
 <detlev.casanova@...labora.com>, <Dharma.B@...rochip.com>,
 <groeck@...omium.org>, <heiko@...ech.de>, <jani.nikula@...el.com>,
 <j@...nau.net>, <jbrunet@...libre.com>, <jesseevg@...il.com>,
 <khilman@...libre.com>, <kieran.bingham+renesas@...asonboard.com>,
 <victor.liu@....com>, <martin.blumenstingl@...glemail.com>,
 <matthias.bgg@...il.com>, <p.zabel@...gutronix.de>, <ple@...libre.com>,
 <fnkl.kernel@...il.com>, <sugar.zhang@...k-chips.com>,
 <sui.jingfeng@...ux.dev>, <tomi.valkeinen+renesas@...asonboard.com>,
 <mordan@...ras.ru>
Subject: Re: [PATCH v2 01/34] drm: convert many bridge drivers from
 devm_kzalloc() to devm_drm_bridge_alloc() API

Hello Manikandan,

On Wed, 30 Apr 2025 09:42:16 +0000
<Manikandan.M@...rochip.com> wrote:

[...]

> > diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> > index 1d4ae0097df847d9f93c79eecff0c4587ae331ba..9f4ff82bc6b49010f8727da3b367f5a744a28edc 100644
> > --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> > +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> > @@ -157,9 +157,10 @@ static int mchp_lvds_probe(struct platform_device *pdev)
> >          if (!dev->of_node)
> >                  return -ENODEV;
> > 
> > -       lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
> > -       if (!lvds)
> > -               return -ENOMEM;
> > +       lvds = devm_drm_bridge_alloc(&pdev->dev, struct mchp_lvds, bridge,
> > +                                    &mchp_lvds_bridge_funcs);
> > +       if (IS_ERR(lvds))
> > +               return PTR_ERR(lvds);
> > 
> >          lvds->dev = dev;
> > 
> > @@ -192,7 +193,6 @@ static int mchp_lvds_probe(struct platform_device *pdev)
> > 
> >          lvds->bridge.of_node = dev->of_node;
> >          lvds->bridge.type = DRM_MODE_CONNECTOR_LVDS;
> > -       lvds->bridge.funcs = &mchp_lvds_bridge_funcs;
> > 
> >          dev_set_drvdata(dev, lvds);
> >          ret = devm_pm_runtime_enable(dev);  
> 
> Reviewed-by: Manikandan Muralidharan <manikandan.m@...rochip.com>

Thanks for reviewing!

In v3 this patch will be slightly different from v2. See the reply I
just sent to Doug for the details.

If your Reviewed-by tag refers only to the microchip-lvds driver, for
which there will be no change in v3, I think it's correct to take your
tag and add a comment like:

 Reviewed-by: Manikandan Muralidharan <manikandan.m@...rochip.com> # microchip-lvds.c

Anything against this?

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com