[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <07354130-999d-4f8d-9deb-49b72d8e4577@linaro.org>
Date: Wed, 30 Apr 2025 13:18:38 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8750-mtp: Add sound (speakers,
headset codec, dmics)
On 30/04/2025 12:48, Konrad Dybcio wrote:
>>>>>> + /*
>>>>>> + * WCD9395 RX Port 1 (HPH_L/R) <=> SWR1 Port 1 (HPH_L/R)
>>>>>> + * WCD9395 RX Port 2 (CLSH) <=> SWR1 Port 2 (CLSH)
>>>>>> + * WCD9395 RX Port 3 (COMP_L/R) <=> SWR1 Port 3 (COMP_L/R)
>>>>>> + * WCD9395 RX Port 4 (LO) <=> SWR1 Port 4 (LO)
>>>>>> + * WCD9395 RX Port 5 (DSD_L/R) <=> SWR1 Port 5 (DSD_L/R)
>>>>>> + * WCD9395 RX Port 6 (HIFI_PCM_L/R) <=> SWR1 Port 9 (HIFI_PCM_L/R)
>>>>>> + */
>>>>>> + qcom,rx-port-mapping = <1 2 3 4 5 9>;
>>>>>
>>>>> Does this deserve some dt-bindings constants?
>>>>
>>>> No, because these are hardware details/constants. Drivers do not use them.
>>>
>>> I'd argue it makes sense here - it makes more sense to pass meaningfully
>>> named constants to the driver, rather than blobs with a comment
>>
>> Sense of what? You want to make it a binding then answer what does it
>> bind, what part of ABI for driver is here a binding (answer none:
>> because driver does not use it)?
>
> Sense of the magic numbers that otherwise require a comment.
>
> dt-bindings don't exclusively contain enums-turned-defines that are
No, they don't.
Best regards,
Krzysztof
Powered by blists - more mailing lists