linux-kernel - Re: [PATCH v1] i2c: microchip-corei2c: add smbus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3421bf4a-afa1-4b4c-8421-bad7187d3d8e@quicinc.com>
Date: Wed, 30 Apr 2025 17:06:09 +0530
From: Mukesh Kumar Savaliya <quic_msavaliy@...cinc.com>
To: Conor Dooley <conor@...nel.org>, <linux-i2c@...r.kernel.org>
CC: prashanth kumar burujukindi <prashanthkumar.burujukindi@...rochip.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Daire McNamara
	<daire.mcnamara@...rochip.com>,
        Andi Shyti <andi.shyti@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] i2c: microchip-corei2c: add smbus support



On 4/30/2025 4:53 PM, Conor Dooley wrote:
> From: prashanth kumar burujukindi <prashanthkumar.burujukindi@...rochip.com>
> 
> In this driver the supported SMBUS commands are smbus_quick,
> smbus_byte, smbus_byte_data, smbus_word_data and smbus_block_data.
> 
Write completely in imperative mood. something like :

Add support for SMBUS commands in driver

Add support for SMBUS commands: smbus_quick, smbus_byte, 
smbus_byte_data, smbus_word_data, and smbus_block_data.

Also mention below limitations here .
SMBUS block read is supported by the controller but has not been tested 
due to lack of hardware. However, SMBUS I2C block read has been tested.

> Signed-off-by: prashanth kumar burujukindi <prashanthkumar.burujukindi@...rochip.com>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> smbus block read is not tested, due to lack of hardware, but is supported
> by the controller, although we have tested smbus i2c block read.
> 
> CC: Conor Dooley <conor.dooley@...rochip.com>
> CC: Daire McNamara <daire.mcnamara@...rochip.com>
> CC: Andi Shyti <andi.shyti@...nel.org>
> CC: linux-i2c@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> ---
>   drivers/i2c/busses/i2c-microchip-corei2c.c | 102 +++++++++++++++++++++
>   1 file changed, 102 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-microchip-corei2c.c b/drivers/i2c/busses/i2c-microchip-corei2c.c

[...]