linux-kernel - Re: [PATCH v1] rust: time: Avoid 64-bit integer division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=kHzATUO_H=cVsuak0dajPH05toyjW+TBMovKid57zCQ@mail.gmail.com>
Date: Thu, 1 May 2025 11:22:27 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	a.hindborg@...sung.com, boqun.feng@...il.com, frederic@...nel.org, 
	lyude@...hat.com, tglx@...utronix.de, anna-maria@...utronix.de, 
	jstultz@...gle.com, sboyd@...nel.org, ojeda@...nel.org, alex.gaynor@...il.com, 
	gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, 
	aliceryhl@...gle.com, tmgross@...ch.edu, chrisi.schrefl@...il.com, 
	arnd@...db.de, linux@...linux.org.uk
Subject: Re: [PATCH v1] rust: time: Avoid 64-bit integer division

On Thu, May 1, 2025 at 3:58 AM FUJITA Tomonori
<fujita.tomonori@...il.com> wrote:
>
> +s64 rust_helper_ktime_to_us(const ktime_t kt)
> +{
> +       return ktime_divns(kt, NSEC_PER_USEC);
> +}
> +
> +s64 rust_helper_ktime_to_ms(const ktime_t kt)
> +{
> +       return ktime_divns(kt, NSEC_PER_MSEC);
> +}

In general, we want to keep helpers mapping to the functions as close
as possible to the C side (e.g. same arguments), unless there is a
good reason not to -- but since you are changing it, let's review
v2...

Cheers,
Miguel