linux-kernel - Re: [PATCH v6 3/5] arm64: dts: exynos: add initial support for Samsung Galaxy J7 Prime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fe07fef083daed35898e8a1d11b6d2d@disroot.org>
Date: Thu, 01 May 2025 11:01:53 +0000
From: Kaustabh Chakraborty <kauschluss@...root.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Kees Cook <kees@...nel.org>, Tony Luck <tony.luck@...el.com>, "Guilherme G.
 Piccoli" <gpiccoli@...lia.com>, Ivaylo Ivanov
 <ivo.ivanov.ivanov1@...il.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v6 3/5] arm64: dts: exynos: add initial support for
 Samsung Galaxy J7 Prime

On 2025-05-01 10:13, Krzysztof Kozlowski wrote:
> On 13/04/2025 20:58, Kaustabh Chakraborty wrote:
>> +		key-volup {
>> +			label = "Volume Up Key";
>> +			gpios = <&gpa2 0 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_VOLUMEUP>;
>> +		};
>> +	};
>> +
>> +	memory@...00000 {
>> +		device_type = "memory";
>> +		reg = <0x0 0x40000000 0x3e400000>;
>> +	};
>> +
>> +	memory@...00000 {
> 
> Why are these two separate device nodes, instead of one for two ranges?
> Does device has somehow two independent memory controllers?

This is from Galaxy J6:

	memory@...00000 {
		device_type = "memory";
		reg = <0x0 0x40000000 0x3d800000>;
	};

	memory@...00000 {
		device_type = "memory";
		reg = <0x0 0x80000000 0x40000000>;
	};

changes to

	memory@...00000 {
		device_type = "memory";
		reg = <0x0 0x40000000 0x3d800000>,
		      <0x0 0x80000000 0x7d800000>;
	};

I assume I have changed it correctly? `free -h` displays the full
and correct memory capacity.

> 
> 
> Best regards,
> Krzysztof