linux-kernel - Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB95QATpPN_jGK7HvwqeWSPU9f15x26j66K2sUDk0pf5b=4NBw@mail.gmail.com>
Date: Thu, 1 May 2025 14:44:48 +0200
From: Eugene Shalygin <eugene.shalygin@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Alexei Safin <a.safin@...a.ru>, Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add WARN_ONCE() on invalid
 sensor index

On Thu, 1 May 2025 at 14:34, Guenter Roeck <linux@...ck-us.net> wrote:

> You do have an excellent point, though: The messages should display the
> sensor type and channel. As for logging it every time: No, because _if_
> there is a programming error it would clog the log, so once is enough
> to tell "something is wrong with the code, fix it". The same is actually
> true if the hardware changes "under the hood".

But WARM_ONCE() can not behave the way we want, as far as I
understand, printing a single warning for each sensor type and
channel, can it?

> Regarding RAM errors: Those won't be caught by checks like this. You'd have
> to litter the whole kernel with checks at almost every line of code
> to even have a remote chance to catch problems like bit flips. Even
> then you'd still not catch cases where the code itself is changed.
> Even trying to catch that would be futile.

I already had a bug report (race condition in this driver, another log
message in the code) that kept me puzzled until the user reported that
it was caused by a malfunctioning RAM module.

Eugene