linux-kernel - Re: [PATCH v1] rust: time: Avoid 64-bit integer division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72m8RfL5g9kmAhZdZZbrpDschrXf1yJVvkWmvMzdnMaSvA@mail.gmail.com>
Date: Thu, 1 May 2025 15:22:00 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Boqun Feng <boqun.feng@...il.com>
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, a.hindborg@...sung.com, frederic@...nel.org, 
	lyude@...hat.com, tglx@...utronix.de, anna-maria@...utronix.de, 
	jstultz@...gle.com, sboyd@...nel.org, ojeda@...nel.org, alex.gaynor@...il.com, 
	gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, 
	aliceryhl@...gle.com, tmgross@...ch.edu, chrisi.schrefl@...il.com, 
	arnd@...db.de, linux@...linux.org.uk
Subject: Re: [PATCH v1] rust: time: Avoid 64-bit integer division

On Thu, May 1, 2025 at 3:12 PM Boqun Feng <boqun.feng@...il.com> wrote:
>
>         #[cfg(CONFIG_ARM)]
>         fn ns_to_ms(ns: i64) -> i64 {
>
>         #[cfg(not(CONFIG_ARM))]
>         fn ns_to_ms(ns: i64) -> i64 {

I think `cfg`s may be better inside, i.e. as local as reasonably
possible, so that we share e.g. signature as well as any attributes
and docs.

Cheers,
Miguel