linux-kernel - Re: [PATCH v2 17/21] rust: num: Add an upward alignment helper for usize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaf5b0cf138c32135781977a7774bfd4572286b5.camel@nvidia.com>
Date: Thu, 1 May 2025 15:19:35 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dakr@...nel.org" <dakr@...nel.org>, "a.hindborg@...nel.org"
	<a.hindborg@...nel.org>, "ojeda@...nel.org" <ojeda@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "corbet@....net" <corbet@....net>,
	"mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"benno.lossin@...ton.me" <benno.lossin@...ton.me>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Alexandre Courbot
	<acourbot@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>
CC: Alistair Popple <apopple@...dia.com>, John Hubbard <jhubbard@...dia.com>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Joel Fernandes
	<joelagnelf@...dia.com>, Ben Skeggs <bskeggs@...dia.com>
Subject: Re: [PATCH v2 17/21] rust: num: Add an upward alignment helper for
 usize

On Thu, 2025-05-01 at 21:58 +0900, Alexandre Courbot wrote:


> +impl UsizeAlign for usize {
> +    fn align_up(mut self, align: usize) -> usize {
> +        self = (self + align - 1) & !(align - 1);
> +        self
> +    }
> +}
> +
> +/// Aligns `val` upwards to the nearest multiple of `align`.
> +pub const fn usize_align_up(val: usize, align: usize) -> usize {
> +    (val + align - 1) & !(align - 1)
> +}

Why not have usize_align_up() just return "val.align_up(align)"?

But why why two versions at all?  Is there any context where you could use one
and not the other?