linux-kernel - Re: [PATCH v1 1/1] bus: ti-sysc: PRUSS OCP configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7htt64urvi.fsf@baylibre.com>
Date: Thu, 01 May 2025 11:07:29 -0700
From: Kevin Hilman <khilman@...libre.com>
To: Parvathi Pudi <parvathi@...thit.com>, aaro.koskinen@....fi,
 andreas@...nade.info, rogerq@...nel.org, tony@...mide.com
Cc: linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, nm@...com,
 pratheesh@...com, prajith@...com, vigneshr@...com, danishanwar@...com,
 praneeth@...com, srk@...com, rogerq@...com, afd@...com,
 krishna@...thit.com, pmohan@...thit.com, mohan@...thit.com,
 parvathi@...thit.com, basharath@...thit.com
Subject: Re: [PATCH v1 1/1] bus: ti-sysc: PRUSS OCP configuration

Parvathi Pudi <parvathi@...thit.com> writes:

> Updates OCP master port configuration to enable memory access outside
> of the PRU-ICSS subsystem.
>
> This set of changes configures PRUSS_SYSCFG.STANDBY_INIT bit to enable
> the OCP master ports during resume sequence and disables the OCP master
> ports during suspend sequence (applicable only on SoCs using OCP
> interconnect like the OMAP family).
>
> Signed-off-by: Parvathi Pudi <parvathi@...thit.com>
> ---
>  drivers/bus/ti-sysc.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> index f67b927ae4ca..51caae611acf 100644
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2036,6 +2036,19 @@ static void sysc_module_disable_quirk_pruss(struct sysc *ddata)
>  	sysc_write(ddata, ddata->offsets[SYSC_SYSCONFIG], reg);
>  }
>  
> +static void sysc_module_enable_quirk_pruss(struct sysc *ddata)
> +{
> +	u32 reg;
> +
> +	reg = sysc_read(ddata, ddata->offsets[SYSC_SYSCONFIG]);
> +	/* Clearing the SYSC_PRUSS_STANDBY_INIT bit - Updates OCP master
> +	 * port configuration to enable memory access outside of the
> +	 * PRU-ICSS subsystem.
> +	 */

minor nit: incorrect multi-line comment style (first /* should be on
line of its own)

But I fixed this up locally before applying.

Kevin