linux-kernel - RE: [PATCH 2/2] mm/gup: Remove page_folio() in memfd_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA0PR11MB71854F7F2A30A7004FA28D5BF8822@IA0PR11MB7185.namprd11.prod.outlook.com>
Date: Thu, 1 May 2025 21:23:46 +0000
From: "Kasireddy, Vivek" <vivek.kasireddy@...el.com>
To: "Vishal Moola (Oracle)" <vishal.moola@...il.com>, "linux-mm@...ck.org"
	<linux-mm@...ck.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Andrew
 Morton" <akpm@...ux-foundation.org>
Subject: RE: [PATCH 2/2] mm/gup: Remove page_folio() in memfd_pin_folios()

Hi Vishal,

> Subject: [PATCH 2/2] mm/gup: Remove page_folio() in memfd_pin_folios()
> 
> We can get the folio directly from the folio batch, so remove the
> unnecessary page_folio() call.
> 
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@...il.com>
> ---
>  mm/gup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 1fb8f3b9a493..795fd94f379d 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -3640,7 +3640,7 @@ long memfd_pin_folios(struct file *memfd, loff_t
> start, loff_t end,
>  			}
> 
>  			for (i = 0; i < nr_found; i++) {
> -				folio = page_folio(&fbatch.folios[i]->page);
> +				folio = fbatch.folios[i];
I don't recall why I chose to extract the folio in a roundabout way. LGTM.

Acked-by: Vivek Kasireddy <vivek.kasireddy@...el.com>

Thanks,
Vivek

> 
>  				if (try_grab_folio(folio, 1, FOLL_PIN)) {
>  					folio_batch_release(&fbatch);
> --
> 2.49.0