linux-kernel - Re: [PATCH] hwmon: (asus-ec-sensors) check sensor index in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <745427d1-3c2d-4ad4-90b5-773466aa269e@roeck-us.net>
Date: Thu, 1 May 2025 20:07:57 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Alexei Safin <a.safin@...a.ru>
Cc: Eugene Shalygin <eugene.shalygin@...il.com>,
	Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] hwmon: (asus-ec-sensors) check sensor index in
 read_string()

On Thu, Apr 24, 2025 at 11:26:54PM +0300, Alexei Safin wrote:
> Prevent a potential invalid memory access when the requested sensor
> is not found.
> 
> find_ec_sensor_index() may return a negative value (e.g. -ENOENT),
> but its result was used without checking, which could lead to
> undefined behavior when passed to get_sensor_info().
> 
> Add a proper check to return -EINVAL if sensor_index is negative.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: d0ddfd241e57 ("hwmon: (asus-ec-sensors) add driver for ASUS EC")
> Signed-off-by: Alexei Safin <a.safin@...a.ru>

Since we can't agree on warn or not or how, I decided to apply this
version after changing the error return value as suggested.

Guenter