linux-kernel - Re: [PATCH v1 1/1] ACPI: VIOT: Remove (explicitly) unused header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250502151537.GA2724505@myrica>
Date: Fri, 2 May 2025 16:15:37 +0100
From: Jean-Philippe Brucker <jean-philippe@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Robin Murphy <robin.murphy@....com>, linux-acpi@...r.kernel.org,
	iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 1/1] ACPI: VIOT: Remove (explicitly) unused header

On Mon, Mar 31, 2025 at 10:23:11AM +0300, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
> 
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Jean-Philippe Brucker <jean-philippe@...aro.org>

> ---
>  drivers/acpi/viot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/viot.c b/drivers/acpi/viot.c
> index 2aa69a2fba73..c13a20365c2c 100644
> --- a/drivers/acpi/viot.c
> +++ b/drivers/acpi/viot.c
> @@ -19,11 +19,11 @@
>  #define pr_fmt(fmt) "ACPI: VIOT: " fmt
>  
>  #include <linux/acpi_viot.h>
> -#include <linux/fwnode.h>
>  #include <linux/iommu.h>
>  #include <linux/list.h>
>  #include <linux/pci.h>
>  #include <linux/platform_device.h>
> +#include <linux/property.h>
>  
>  struct viot_iommu {
>  	/* Node offset within the table */
> -- 
> 2.47.2
>