linux-kernel - Re: [PATCH] nvme-pci: Fix system hang when ASPM L1 is enabled during suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87820fb9-cfd4-4b7c-b015-9626d5253a5f@cixtech.com>
Date: Sat, 3 May 2025 00:04:43 +0800
From: Hans Zhang <hans.zhang@...tech.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
 linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org
Subject: Re: [PATCH] nvme-pci: Fix system hang when ASPM L1 is enabled during
 suspend



On 2025/5/2 23:45, Manivannan Sadhasivam wrote:
> On Fri, May 02, 2025 at 11:20:51AM +0800,hans.zhang@...tech.com  wrote:
>> From: Hans Zhang<hans.zhang@...tech.com>
>>
>> When PCIe ASPM L1 is enabled (CONFIG_PCIEASPM_POWERSAVE=y), certain
>> NVMe controllers fail to release LPI MSI-X interrupts during system
>> suspend, leading to a system hang. This occurs because the driver's
>> existing power management path does not fully disable the device
>> when ASPM is active.
>>
> Why can't you add quirks for those NVMe devices instead?
> 

Dear Mani,

static int nvme_init_identify(struct nvme_ctrl *ctrl)
   if (!ctrl->identified) {
     for (i = 0; i < ARRAY_SIZE(core_quirks); i++) {
	if (quirk_matches(id, &core_quirks[i]))
	  ctrl->quirks |= core_quirks[i].quirks;
	}


quirk_matches needs to match the vid of each NVMe SSD. At present, I 
have added all the vid available on the market to the quirks table, 
which seems very unreasonable.

Best regards,
Hans