linux-kernel - Re: [PATCH] fs: minix: Fix handling of corrupted directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250502171316.GY2023217@ZenIV>
Date: Fri, 2 May 2025 18:13:16 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Andrey Kriulin <kitotavrik.s@...il.com>
Cc: Christian Brauner <brauner@...nel.org>,
	Andrey Kriulin <kitotavrik.media@...il.com>,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Josef Bacik <josef@...icpanda.com>, NeilBrown <neilb@...e.de>,
	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org, stable@...r.kernel.org
Subject: Re: [PATCH] fs: minix: Fix handling of corrupted directories

On Fri, May 02, 2025 at 07:50:57PM +0300, Andrey Kriulin wrote:
> If the directory is corrupted and the number of nlinks is less than 2 
> (valid nlinks have at least 2), then when the directory is deleted, the
> minix_rmdir will try to reduce the nlinks(unsigned int) to a negative
> value.
> 
> Make nlinks validity check for directory in minix_lookup.
 
Not sure it's a good mitigation strategy - if nothing else, doing that
on r/o filesystem is clear loss...