linux-kernel - Re: [PATCH v12 17/21] futex: Implement FUTEX2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250502184542.GA24078@noisy.programming.kicks-ass.net>
Date: Fri, 2 May 2025 20:45:42 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org,
	André Almeida <andrealmeid@...lia.com>,
	Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>, Ingo Molnar <mingo@...hat.com>,
	Juri Lelli <juri.lelli@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v12 17/21] futex: Implement FUTEX2_MPOL

On Wed, Apr 16, 2025 at 06:29:17PM +0200, Sebastian Andrzej Siewior wrote:
> @@ -342,18 +411,20 @@ struct futex_hash_bucket *futex_hash(union futex_key *key)
>  static struct futex_hash_bucket *
>  __futex_hash(union futex_key *key, struct futex_private_hash *fph)
>  {
> -	struct futex_hash_bucket *hb;
> +	int node = key->both.node;
>  	u32 hash;
> -	int node;
>  
> -	hb = __futex_hash_private(key, fph);
> -	if (hb)
> -		return hb;
> +	if (node == FUTEX_NO_NODE) {
> +		struct futex_hash_bucket *hb;
> +
> +		hb = __futex_hash_private(key, fph);
> +		if (hb)
> +			return hb;
> +	}
>  
>  	hash = jhash2((u32 *)key,
>  		      offsetof(typeof(*key), both.offset) / sizeof(u32),
>  		      key->both.offset);
> -	node = key->both.node;
>  
>  	if (node == FUTEX_NO_NODE) {
>  		/*

I *think* this hunk should've been in the previous patch; because it
changes the behaviour of FUTEX2_NUMA (to the better).

Anyway, nevermind, just wanted to point it out.