[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250502224512.it.706-kees@kernel.org>
Date: Fri, 2 May 2025 15:54:12 -0700
From: Kees Cook <kees@...nel.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Kees Cook <kees@...nel.org>,
Nathan Chancellor <nathan@...nel.org>,
Nicolas Schier <nicolas.schier@...ux.dev>,
Petr Pavlu <petr.pavlu@...e.com>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Justin Stitt <justinstitt@...gle.com>,
Marco Elver <elver@...gle.com>,
Andrey Konovalov <andreyknvl@...il.com>,
Andrey Ryabinin <ryabinin.a.a@...il.com>,
Richard Weinberger <richard@....at>,
Anton Ivanov <anton.ivanov@...bridgegreys.com>,
Johannes Berg <johannes@...solutions.net>,
linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org,
linux-kbuild@...r.kernel.org,
kasan-dev@...glegroups.com,
linux-um@...ts.infradead.org
Subject: [PATCH v2 0/3] Detect changed compiler dependencies for full rebuild
v2:
- switch from -include to -I with a -D gated include compiler-version.h
v1: https://lore.kernel.org/lkml/20250501193839.work.525-kees@kernel.org/
Hi,
This is my attempt to introduce dependencies that track the various
compiler behaviors that may globally change the build that aren't
represented by either compiler flags nor the compiler version
(CC_VERSION_TEXT). Namely, this is to detect when the contents of a
file the compiler uses changes. We have 3 such situations currently in
the tree:
- If any of the GCC plugins change, we need to rebuild everything that
was built with them, as they may have changed their behavior and those
behaviors may need to be synchronized across all translation units.
(The most obvious of these is the randstruct GCC plugin, but is true
for most of them.)
- If the randstruct seed itself changes (whether for GCC plugins or
Clang), the entire tree needs to be rebuilt since the randomization of
structures may change between compilation units if not.
- If the integer-wrap-ignore.scl file for Clang's integer wrapping
sanitizer changes, a full rebuild is needed as the coverage for wrapping
types may have changed, once again cause behavior differences between
compilation units.
The best way I found to deal with this is to:
- Generate a .h file that is updated when the specific dependencies change.
e.g.: randstruct_hash.h depends on randstruct.seed
- Add a -I argument globally to be able to locate the .h file.
e.g.: -I$(objtree)/scripts/basic
- Add a conditional -D argument for each separate case
e.g.: RANDSTRUCT_CFLAGS += -DRANDSTRUCT
- Include the .h file from compiler-version.h through an #ifdef for the define
e.g.:
#ifdef RANDSTUCT
#include "randstruct_hash.h"
#endif
This means that all targets gain the dependency (via fixdep), but only
when the defines are active, which means they are trivially controlled
by the existing CFLAGS removal mechanisms that are already being used
to turn off each of the above features.
-Kees
Kees Cook (3):
gcc-plugins: Force full rebuild when plugins change
randstruct: Force full rebuild when seed changes
integer-wrap: Force full rebuild when .scl file changes
Makefile | 1 +
arch/um/Makefile | 2 ++
include/linux/compiler-version.h | 10 ++++++++++
include/linux/vermagic.h | 1 -
scripts/Makefile.gcc-plugins | 2 +-
scripts/Makefile.ubsan | 1 +
scripts/basic/Makefile | 20 +++++++++++++++-----
scripts/gcc-plugins/Makefile | 8 ++++++++
8 files changed, 38 insertions(+), 7 deletions(-)
--
2.34.1
Powered by blists - more mailing lists