linux-kernel - Re: [PATCH 5/6] arm64: dts: ls1028a-qds: make the QIXIS CPLD use the simple-mfd-i2c.c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250502-savvy-eccentric-hog-b4fed5@kuoka>
Date: Fri, 2 May 2025 09:04:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ioana Ciornei <ioana.ciornei@....com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH 5/6] arm64: dts: ls1028a-qds: make the QIXIS CPLD use the
 simple-mfd-i2c.c driver

On Wed, Apr 30, 2025 at 06:36:33PM GMT, Ioana Ciornei wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> The MDIO mux on the LS1028A-QDS never worked in mainline. The device
> tree was submitted as-is, and there is a downstream driver for the QIXIS
> FPGA:
> 
> https://github.com/nxp-qoriq/linux/blob/lf-6.12.y/drivers/soc/fsl/qixis_ctrl.c
> 
> That driver is very similar to the already existing drivers/mfd/simple-mfd-i2c.c,
> and the hardware works with the simple-mfd-i2c driver, so there isn't
> any reason to upstream the other one.
> 
> Adapt the compatible string and child node format of the FPGA node, so
> that the simple-mfd-i2c driver accepts it.

Why do you break the users based on some driver differences? Fix the
drivers, not the DTS.

> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 0bb2f28a0441..58b54d521d75 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -338,17 +338,18 @@ sgtl5000: audio-codec@a {
>  	};
>  
>  	fpga@66 {
> -		compatible = "fsl,ls1028aqds-fpga", "fsl,fpga-qixis-i2c",
> -			     "simple-mfd";
> +		compatible = "fsl,ls1028a-qds-qixis-i2c";

This breaks all the existing users. NAK.

>  		reg = <0x66>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
>  
> -		mux: mux-controller {
> +		mux: mux-controller@54 {

This was never tested. Your binding says something else.

>  			compatible = "reg-mux";
> +			reg = <0x54>;
>  			#mux-control-cells = <1>;
>  			mux-reg-masks = <0x54 0xf0>; /* 0: reg 0x54, bits 7:4 */
>  		};
>  	};
> -
>  };
>  
>  &i2c1 {
> -- 
> 2.25.1
>